Permalink
Commits on Aug 31, 2011
  1. Teach CommandT::Stub to handle show_buffer_finder

    If for some reason you didn't compile the extension before trying to use
    the buffer finder you would trigger an error because the CommandT::Stub
    class didn't implement the #show_buffer_finder method.
    
    As the number of stubbed methods has now reached three, this commit also
    includes a refactoring to eliminate the repetition in the method
    definitions.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Aug 31, 2011
Commits on Jun 30, 2011
  1. Reverting lazy-initialization code, pending investigation

    This commit rolls back the recently-added lazy-initialization code due
    to a report of a segfault; due to the fact that a lot of people use
    Pathogen or similar to track the HEAD of master, I'd rather be
    conservative about this and roll it back immediately, and then
    investigate. The lazy-initialization code itself has been moved onto a
    topic branch (lazy-initialization).
    
    The bug report:
    
      https://wincent.com/issues/1837
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Jun 30, 2011
  2. Correct Kien's name in docs and .mailmap file

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Jun 30, 2011
Commits on Jun 29, 2011
  1. Update docs with reference to Kien's patch

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Jun 29, 2011
  2. Fixes for lazy-initialization functionality

    This commit addresses some problems with the lazy-initialization
    functionality contributed in commit 86e87ab. Specifically:
    
      - Rename Initialize function to CommandTLazyInitialize for consistency
        with all other functions (which are namespaced under "CommandT") and
        also to better describe the purpose of the function
      - Remove now-redundant "has('ruby')" check
      - Guard against repeated evaluation of the initialization function,
        which would otherwise cause a new controller instance to be created
        every time a Command-T command is run
      - Fix indentation
      - Fix bad whitespace (blank line at end of file)
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Jun 29, 2011
  3. Move ruby startup code to script local function

    Command-T takes about 320 ms to load on Vim startup. This is a lot
    considering most other plugins takes less than 1 ms. In this pull
    request I move the ruby startup code in command-t.vim to a script local
    function and only call it when user uses Command-T. With this change,
    command-t.vim takes less than 1 ms to load at Vim startup.
    
    Via:
    
      wincent#14
    kien committed with wincent Jun 28, 2011
Commits on May 4, 2011
  1. Remove "install" Rake task as it is causing confusion

    Looks like some people/scripts saw the "rake install" task and thought
    that was the way to install the Command-T plug-in in Vim, but it is not:
    
      carlhuda/janus#163
    
    Remove the task to avoid such confusion. People who want to install the
    Gem can still do so with "gem install command-t", which is easy enough.
    
    (And to anyone reading this commit message, note that the gem was added
    so that third-parties could access the Command-T matching algorithm from
    outside of Vim, but to get the full functionality from inside Vim, you
    must continue to install it as always, as a Vim plug-in and not as a
    gem. See the docs for how to do this.)
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed May 4, 2011
Commits on May 1, 2011
  1. Update docs for 1.2.1 release

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed May 1, 2011
  2. Extract cursor movement into separate method

    This is more intention-revealing.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed May 1, 2011
  3. Move cursor to selected line in match window

    In GUI Vim (eg MacVim) the cursor correctly hides, but when running in a
    terminal it does not. By moving the cursor to the currently selected
    line we at least minimize the visual distraction when it starts
    blinking (at least it draws the eye to the selected line rather than
    blinking in the upper-left corner).
    
    For related discussion see:
    
      pMongoose/Command-T@7e3e5f9
    
    It may be possible to teach some kinds of terminal, such as xterm, to
    actually hide the cursor, but that will be a task for later development:
    
      http://vim.wikia.com/wiki/Configuring_the_cursor
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    Steven Moazami committed with wincent Apr 22, 2011
  4. Rakefile: update "help" task with info about new tasks

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed May 1, 2011
  5. Fix botched commit 2328b94

    We were supposed to swap the symlink and the file; ie:
    
      README.txt (real file)
      doc/command-t.txt (symlink)
    
    Was supposed to become:
    
      README.txt (symlink)
      doc/command-t.txt (real file)
    
    But we ended up adding a duplicate copy of the documentation:
    
      README.txt (symlink to doc/README.txt)
      doc/README.txt (real file)
      doc/command-t.txt (real file)
    
    This commit fixes that, removing the redundant doc/README.txt and making
    sure that doc/command-t.txt contains all recent changes.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed May 1, 2011
Commits on Apr 30, 2011
  1. Shorten description in gemspec

    The long description looks terrible on the RubyGems.org website, so trim
    it down to the bare minimum.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  2. Update docs for 1.2 release

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  3. Add Victor Hugo Borja to the README credits

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  4. Add 'push' task for publishing to Gemcutter

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  5. Clarify RubyGem description

    Add a paragraph explaining that Command-T is a Vim plug-in first and
    foremost, and that full functionality is only available when installed
    as a Vim plug-in, but that it is also packaged as a RubyGem so that
    third-party applications can make use of the search algorithm.
    wincent committed Apr 30, 2011
  6. Warn about making non-release gems

    Abbreviating the full version number of an intermediate build (eg.
    "1.1b2-10-g61a374a") to the last tag (eg. "1.1b2") is evil, because it
    means we end up labelling distinct versions of the software with the
    same version number.
    
    Unfortuantely, however, it is a necessary evil because RubyGems will
    choke if passed an intermediate version number:
    
      Invalid gemspec in [command-t.gemspec]: Malformed version number string
      1.1b2-10-g61a374a
      ERROR:  While executing gem ... (NoMethodError)
          undefined method `mark_version' for nil:NilClass
          rake aborted!
    
    So, we resort to using the abbreviated, misleading version number in
    this case. We can at least mitigate this evilness by displaying a
    warning if the user ever tries to build a gem for an intermediate
    release, by adding a dependency on the ":check_tag" task.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  7. Added command-t.gemspec and :gem, :install targets to Rakefile

    This will allow other applications to use Command-T ruby binding.
    Currently another app uses it besides Command-T vim plugin itself:
    
    mrT [http://github.com/vic/mrT] - Curses based file completion
                                      for the command line.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    vic committed with wincent Mar 17, 2011
  8. Add Daniel Hahler to README credits

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  9. Swap README.txt and doc/command-t.txt.

    Make doc/command-t.txt the real file to make helptags work on
    Windows.
    
    Originally README.txt was a symlink, but GitHub didn't follow symlinks,
    so things were swapped. Now, it does, so there's no penalty in swapping
    back.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    blueyed committed with wincent Mar 15, 2011
  10. Fix typo/logic: "on" should be "off"

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    blueyed committed with wincent Feb 23, 2011
  11. Fix alignment problems in help text

    While these tweaks actually make the help text look worse when viewed as
    plain text, they correct alignment problems when rendered inside Vim
    itself as a help document (where some of the markup characters become
    invisible).
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  12. Add Steven Moazami to the README credits

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  13. Don't needlessly redisplay list when showing reversed lists

    The "matches != @matches" comparison would spuriously pass for reversed
    lists, except for the case where the list contains only 1 match, because
    we were comparing the unreversed list with the reversed list.
    
    So, reverse the list before doing the comparison, thus avoiding
    unnecessary reprinting of the matches when the match list is unchanged.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Apr 30, 2011
  14. Added a new option CommandTMatchWindowReverse

    This allows you to reverse the order of the matches, bottom being
    closest match instead of top.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    Steven Moazami committed with wincent Apr 22, 2011
Commits on Mar 27, 2011
  1. Rakefile: add help task

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  2. Rakefile: 'stash pop' failing is not necessarily a bad thing

    If there are no local changes in the tree then the initial 'git stash'
    will be a no-op, emitting:
    
      No local changes to save
    
    Subsequently, when we do 'git stash pop' we'll exit with a non-zero exit
    status and will see:
    
      No stash found.
    
    As this is not really an error, don't make the entire Rake task explode
    when this happens. If there really is an actual error at this point, the
    user will see it from the message.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  3. Update docs for 1.1b2 release

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  4. Rakefile: actually filter release notes

    Filtering was inadvertantly turned off during recent refactoring.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  5. Rakefile: tweaks to get vimscriptuploader.rb working

    Through experimentation, I've found that the way to get
    vimscriptuploader.rb working is to:
    
      - pass upload credentials in via a config file found at
        ~/.vim_org.yml
      - pass the release notes in via a file pointed at by the
        --message-file option
      - pass all other options in via arguments
      - pass in an empty YAML file to keep it from barfing
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  6. Rakefile: pass in script ID on the commandline rather than via file

    vimscriptupload.rb will choke if we try to pass the script ID in through
    the configuration file, because when the Yaml file is read back in, the
    "id" key appears as a symbol rather than a string, and it is looking for
    a string only.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  7. Rakefile: update bail_on_failure method to use colorized output

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  8. Rakefile: check for Bundler before attempting to upload to www.vim.org

    If not present, issue a warning, because the upload task will fail
    unless the Mechanize gem is installed on the system.
    
    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011
  9. Rakefile: abort upload if editor returns non-zero exit status

    Signed-off-by: Wincent Colaiuta <win@wincent.com>
    wincent committed Mar 27, 2011