Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Some fixes for auto views #6

Merged
19 commits merged into from Nov 26, 2010

Conversation

Projects
None yet
2 participants
Contributor

maritz commented Nov 23, 2010

Hey,

I finally came around to merging your upstream changes and pushing my fixes for the automatic view renderer and router.

I think I made a bit of a mess in the merge process, regarding my commit history. Sorry about that. But I hope it gets normalized if you pull this.

Let me know what you think and hopefully I can use npm ni soon again. :)

Greetings,
mAritz

Contributor

maritz commented Nov 23, 2010

Looking at the "Files changed" tab of this pull request I think everything should be just fine for a simple pull.

Btw: I'm building my second node.js app with Ni and am testing all my changes with that. If you want to have a look at how I'm using it: http://github.com/maritz/e-Tourney

edit: cleaned up my app. not such a bad mess anymore :)

Owner

chetan51 commented Nov 24, 2010

Cool, looks good. One thing though, we're not using var root = this.__root anymore, all configuration values (system and custom) are now accessed with Ni.config(). So to get the path of the root folder, instead use var root = this.config('root'). This is applicable for your commit "Add root dir to automatic view filenames".

Contributor

maritz commented Nov 26, 2010

Yeah, I know. The commit log is a bit misleading.

If you look at the "Files Changed" tab at the top you'll see what will actually be merged. I already corrected it to Ni.config in the merging process. (Since before that I didn't have Ni.config() but only this.__root)
The Changes are only ~3 lines, should all be fine.

Owner

chetan51 commented Nov 26, 2010

Okay, it's all merged.

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment