[#3418] Build for Ubuntu 16.04 and update Linux, OpenBSD and OSX builds to cffi. #54
Conversation
adiroiban
changed the title
|
windows builder is green. arch and ubuntu-1604 also working to enable for all ubuntu versions ...at lease for the supported ones later we should also enable RHEL and SLES needs-review |
|
Since I was already set on this I tried to enable as many systems as possible... and OpenBSD is now updated. but there is still work for freebsd ... and aix :) |
| fi | ||
| BUILD_CFFI="yes" |
There was a problem hiding this comment.
I guess the above line should come inside the else clause and before the ending fi clause. Consequently, the Solaris 10 builds are broken, eg. https://build.chevah.com/builders/python-package-solaris-10/builds/76/steps/build/logs/stdio
There was a problem hiding this comment.
hm.... in master CFFI is build for any solaris version ... so I think that this is just keeping the behavior from master
|
Some minor comments above… However, the Solaris 10 builds are broken, thus: needs-changes |
|
Also, Solaris 11 for Sparc has a mysterious issue (unrelated to the generic Solaris 10 one). For details: https://build.chevah.com/builders/python-package-solaris-11-sparc/builds/35/steps/build/logs/stdio |
|
the build is broken on solaris since libffi was compiled but not installed on solaris. @dumol I am asking if is ok with you to merge this as it is and have a separate ticket to look at fixing the solaris builds. thanks! needs-review |
|
There are least tree breakages in this:
I'm not happy with breaking six build slaves (of which five are important for our releases) for enabling the newly launched Ubuntu 16.04… But I guess this branch became something else in the process, so the title of this PR should be updated. And tickets for the breakages in master should be added and assigned. I feel this is over the top for me currently… |
|
You are right. I think that AIX and FreeBSD are already left with the old build system and are green. The need to be updated in separate tickets. I will also update the code so that solaris will use the old build system in which libffi is not installed. I will update the ticket title to include osx and the other linux distros Thanks! |
adiroiban
changed the title
adiroiban
changed the title
|
ok... hope this is fixed. needs-review |
| --extract $destination/Lib/site-packages/pywin32_system32/pythoncomloader27.dll.embedded \ | ||
| $destination/Lib/site-packages/pywin32_system32/pythoncomloader27.dll | ||
|
|
||
| execute sed -e 's|version="9.0.21022.8"|version="9.00.30729.6161"|' -e 's|publicKeyToken="1fc8b3b9a1e18e3b"||' < $destination/Lib/site-packages/win32/pythonservice.exe.embedded > $destination/Lib/site-packages/win32/pythonservice.exe.manifest |
There was a problem hiding this comment.
I was also patching these files for service usage. I see that the new version skips them. I have doubts that this is ok.
There was a problem hiding this comment.
this is done... see comment below and changes in chevah_build
|
I saw some changes to the Windows build code that I think was not tested. Please check my comments, thanks. needs-changes |
|
I can confirm all the previously-problematic UNIX builds are now green. |
|
I think that the code is ok. needs-review |
|
changes-approved |
|
looks good and works great on my archlinux. changes-approved |
Oki dok. changes-approved |
Scope
Update build system to create package for ubuntu 16.04
Changes
Since pyopenssl 0.13 no longer works with OpenSSL available on Ubuntu 16.04 i have updated the build system to the one similar to Arch.
In the future all builds should use that system.
I have refactored a bit the windows part to re-use the common process.
src/python/chevahbs no longer installs pip, but just make sure that we have a minimal python.
I have also enable new build system for rhel 5,6,7 and sles 11,12 and generic linux, raspbian7, openbsd and solaris11
aix, freebsd and solaris10 are broken ... but since solaris 10 has a very old openssl I am not sure if we can upgrade it.
As a drive by I have added the github PR template.
How to test
reviewers: @brunogola @dumol @alibotean
check that changes make sense
thanks!