Add support for parsing G1 logs that have decimal values in the log form and -XX:+PrintAdaptiveSizePolicy

[ryangardner]

This pull request adds support for parsing G1 log files that include the -XX:+PrintAdaptiveSizePolicy information (it basically ignores the [G1Ergonomics lines)

Also it supports the decimal format logs that G1 seems to use for me (e.g. 64.3G being one of the values in the log - previously it was parsed as an int and it puked on these decmial values)

The latest update passes all existing unit tests (and the one I added to test the specific thing I'm interested in supporting)

[chewiebug]

Hi Ryan,

Support for -XX:+PrintAdaptiveSizePolicy looks like a very good addition to GCViewer!

I can't reproduce decimal format logs for G1, however. I have had a pull request once that mentioned the same fact (issue #53). There JDK 1.7.0_12-ea-b08 (ea = early adopter) was used. Did you also happen to use that version of the JDK? In the latest JDK 1.7.0_u21 I can't find decimal format logs.

Regards, Jörg

[ryangardner]

Yes, its the 12 ea build with decimal logs.

What is interesting is that the version numbers oracle has are all screwed
up. The 1.7u12 ea build has a NEWER version of Hotspot (build 24) than the
1.7u21 release version.

The hotspot version in the 1.7u12 ea enables a bunch of tuning options for
g1 (some are experimental) that aren't in the release builds.

I think that once a jdk with h24 or h25 version of hotspot is released that
decimal logs for the GC logging will be the norm. (We could ask the hotspot
user list to find out for sure)
On May 12, 2013 3:39 PM, "chewiebug" notifications@github.com wrote:

Hi Ryan,

Support for -XX:+PrintAdaptiveSizePolicy looks like a very good addition
to GCViewer!

I can't reproduce decimal format logs for G1, however. I have had a pull
request once that mentioned the same fact (issue #53#53).
There JDK 1.7.0_12-ea-b08 (ea = early adopter) was used. Did you also
happen to use that version of the JDK? In the latest JDK 1.7.0_u21 I can't
find decimal format logs.

Regards, Jörg

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/65#issuecomment-17783964
.

[chewiebug]

Hi Rayn,

The version number schema of oracle definitely seems screwed up. I have found an article, where they explained a new version strategy. Probably they never used the new strategy on the ea builds (at least not yet). So your assumption that the decimals will make it into the logs sometime is probably safe. I have merged your pull request.

Thank you very much for your contribution!

Regards, Jörg