Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a helper method for Indian English #38

Closed
chgasparoto opened this issue Oct 6, 2019 · 4 comments · Fixed by #45
Closed

Add a helper method for Indian English #38

chgasparoto opened this issue Oct 6, 2019 · 4 comments · Fixed by #45
Assignees
@niyabits
Labels
Hacktoberfest released

Comments

@chgasparoto
Copy link
Owner

See #1 on how to implement it. It's very simple and it's the perfect candidate for the first issue collaboration.

Feel free to post any questions.

Code example: https://github.com/chgasparoto/aws-polly-voices/pull/2/files
@niyabits
Copy link
Contributor

niyabits commented Oct 6, 2019

I am ready to take this issue, just one question, how do I get the mock voice names?

  Gender: 'Male',
  Name: 'Giorgio',
  LanguageName: 'Italian',
  Id: 'Giorgio',
  LanguageCode: 'it-IT'
},```

@chgasparoto
Copy link
Owner Author

@yashguptaz you can extract from the voices.json file.

@niyabits
Copy link
Contributor

niyabits commented Oct 6, 2019

You can review my PR now here,
#45 (comment)

@niyabits niyabits mentioned this issue Oct 7, 2019
Merged
8 tasks
@chgasparoto
Copy link
Owner Author

🎉 This issue has been resolved in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niyabits niyabits

Labels
Hacktoberfest released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Added helper for Indian English niyabits/aws-polly-voices
2 participants
@chgasparoto @niyabits