New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variable in split_audio #5

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
2 participants
@jubalh
Contributor

jubalh commented Jul 10, 2018

No description provided.

@jubalh jubalh referenced this pull request Jul 10, 2018

Open

Adding my own courses #1

Add expected directories to gitignore
output, texts and files directory are used by our scripts to place the
course files in but not intended for upload.

@chickendude chickendude merged commit 1ed4c58 into chickendude:master Jul 11, 2018

@chickendude

This comment has been minimized.

Show comment
Hide comment
@chickendude

chickendude Jul 11, 2018

Owner

I think we can just delete split_audio altogether, though it may be useful if anyone else wants to use the sentence timing method (which is a bit faster) for something.

Owner

chickendude commented Jul 11, 2018

I think we can just delete split_audio altogether, though it may be useful if anyone else wants to use the sentence timing method (which is a bit faster) for something.

@jubalh

This comment has been minimized.

Show comment
Hide comment
@jubalh

jubalh Jul 11, 2018

Contributor

Just let it stay. Better to have it instead of it being gone. Might really be useful in the future. Let's just add a note.

Contributor

jubalh commented Jul 11, 2018

Just let it stay. Better to have it instead of it being gone. Might really be useful in the future. Let's just add a note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment