New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for DEIT to split_gms #8

Merged
merged 1 commit into from Jul 14, 2018

Conversation

Projects
None yet
2 participants
@jubalh
Contributor

jubalh commented Jul 13, 2018

It seems the DEIT course which I own has one more intro text to skip.

Not sure if its the best solution, but at least it will work for users
with that course for now. Maybe we should change it later to something
more general.

It would be good to find out if courses that were released in different
years have a different intro/outro text and whether we can detect this.

Related to #1

Add support for DEIT to split_gms
It seems the DEIT course which I own has one more intro text to skip.

Not sure if its the best solution, but at least it will work for users
with that course for now. Maybe we should change it later to something
more general.

It would be good to find out if courses that were released in different
years have a different intro/outro text and whether we can detect this.

Related to #1

@chickendude chickendude merged commit d119c4e into chickendude:master Jul 14, 2018

@chickendude

This comment has been minimized.

Show comment
Hide comment
@chickendude

chickendude Jul 14, 2018

Owner

I think it was an error on my end, most new courses will be like yours, however i switched to only splitting the C files as it's faster and i already have my base language (EN). I'll test again with my GMS B files to ensure it still works.

Owner

chickendude commented Jul 14, 2018

I think it was an error on my end, most new courses will be like yours, however i switched to only splitting the C files as it's faster and i already have my base language (EN). I'll test again with my GMS B files to ensure it still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment