Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing erb default form for devise #1

Merged
merged 1 commit into from Dec 24, 2017

Conversation

@qczhang18
Copy link
Contributor

qczhang18 commented Apr 25, 2017

Hi, thanks for the great Gem, loving it. I was playing with it and notice ERB for form_for is not generating correctly. Upon inspecting it more closely, I think conversation from HAML to ERB introduces side effects. While I don't know how to fix and test all the coverage, I fix what it works for me. :)

@chiefpansancolt chiefpansancolt self-requested a review Aug 21, 2017
@chiefpansancolt chiefpansancolt self-assigned this Aug 21, 2017
@chiefpansancolt chiefpansancolt merged commit c284aed into chiefpansancolt:master Dec 24, 2017
1 check passed
1 check passed
codeclimate no new or fixed issues
Details
@chiefpansancolt chiefpansancolt added this to the Version 1.1.0 milestone Dec 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.