From a5cf2cff9551c3a78e15db5fdcefb61c55a4fc19 Mon Sep 17 00:00:00 2001 From: Liototo <74362833+Liototo@users.noreply.github.com> Date: Sat, 18 May 2024 21:02:14 +0200 Subject: [PATCH] Improved visualization --- .../collaboration-extension/src/collaboration.ts | 10 +++++----- packages/collaboration/src/activitydotplot.tsx | 14 ++++++++------ 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/packages/collaboration-extension/src/collaboration.ts b/packages/collaboration-extension/src/collaboration.ts index e7092be..dd7f726 100644 --- a/packages/collaboration-extension/src/collaboration.ts +++ b/packages/collaboration-extension/src/collaboration.ts @@ -194,14 +194,14 @@ export const rtcPanelPlugin: JupyterFrontEndPlugin = { app.shell.add(chatPanel, 'left', { rank: 301 }); const chatbox = new Chatbox(user, awarenessProvider, roles); - chatbox.title.label = trans.__('Chat with collaborators'); chatPanel.addWidget(chatbox); - const pollTab = new PollList(user, awarenessProvider, roles); - - pollTab.title.label = trans.__('Polls'); - chatPanel.addWidget(pollTab); + setTimeout(() => { + const pollTab = new PollList(user, awarenessProvider, roles); + pollTab.title.label = trans.__('Polls'); + chatPanel.addWidget(pollTab); + }, 1000); } }; diff --git a/packages/collaboration/src/activitydotplot.tsx b/packages/collaboration/src/activitydotplot.tsx index 7dce3a0..a661b02 100644 --- a/packages/collaboration/src/activitydotplot.tsx +++ b/packages/collaboration/src/activitydotplot.tsx @@ -14,6 +14,8 @@ export const ActivityDotPlot: React.FC = ({tracke const [state, setState] = React.useState([]); + const MIN_HORIZONTAL_RANGE = 20; + React.useEffect(() => { const updateCounts = (notebook: Notebook) => { @@ -59,7 +61,7 @@ export const ActivityDotPlot: React.FC = ({tracke state.forEach((userArray, cellIndex) => { userArray.forEach((user, userIndex) => { - yValues.push(-cellIndex); + yValues.push(-cellIndex - 1); xValues.push(userIndex + 1); hoverText.push(`${user.name} on cell ${cellIndex}`); }); @@ -67,9 +69,9 @@ export const ActivityDotPlot: React.FC = ({tracke }); const maxCellIndex = state.length > 0 ? state.length - 1 : 0 - const tickvals = Array.from(Array(maxCellIndex + 1).keys()).map(index => -index); - const ticktext = Array.from(Array(maxCellIndex + 1).keys()).map(index => index.toString()); - + const tickvals = Array.from(Array(maxCellIndex + 2).keys()).map(index => -index); + const ticktext = Array.from(Array(maxCellIndex + 2).keys()).map(index => (index - 1).toString()); + const maxXvalue = Math.max(...xValues, MIN_HORIZONTAL_RANGE); const data = [{ y: yValues, @@ -87,12 +89,12 @@ export const ActivityDotPlot: React.FC = ({tracke height: 500, xaxis: { title: 'Active users', - range: [1, Math.max(...xValues) + 1] + range: [0.5, maxXvalue] }, yaxis: { title: 'Cell', autorange: false, - range: [-maxCellIndex, 0], + range: [-maxCellIndex - 1.5, -0.5], tickvals: tickvals, ticktext: ticktext },