Skip to content
This repository has been archived by the owner. It is now read-only.

Port wiki section edits #137

Closed

Conversation

@timfel
Copy link
Contributor

timfel commented Dec 2, 2011

Redmine now supports section-wise editing for wikis, which enables multiple users to work on the same wiki page. I have applied the required patches to Chili, their and our tests run.

@edavis10

This comment has been minimized.

Copy link
Contributor

edavis10 commented Dec 2, 2011

-1 Thanks for porting this Tim but sadly the code from Redmine isn't up to the quality I'd like to see in ChiliProject. If you (or someone else) wants to update the pull request I'd be happy to re-review.

  • The code quality is really poor, for example extract_sections is undocumented and complex and there are extra instance variables created in the controllers for things that should be helpers
  • This adds macros back in, which is a regression of the changes from the Liquid
  • This patch is targeting master, which should not get new features. It should target unstable
  • The commits are: actual feature, bugfix for feature, bugfix for feature, etc. They should be squashed into one commit.
@meineerde meineerde closed this Feb 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.