Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mysql-connection-manager with a connection pool #51

Merged
merged 1 commit into from Sep 15, 2016
Merged

Replace mysql-connection-manager with a connection pool #51

merged 1 commit into from Sep 15, 2016

Conversation

@fcarreiro
Copy link
Contributor

@fcarreiro fcarreiro commented Sep 9, 2016

Closes issue #50.

@fcarreiro
Copy link
Contributor Author

@fcarreiro fcarreiro commented Sep 13, 2016

@chill117 does this look kind of ok? ;)

@@ -19,7 +19,7 @@
"debug": "2.2.0",
"depd": "1.1.0",
"express-session": "1.14.0",
"mysql-connection-manager": "0.0.13"
"mysql": "^2.11.1"
Copy link
Owner

@chill117 chill117 Sep 15, 2016

I prefer hard-coded/static version numbers for all dependencies.

@chill117
Copy link
Owner

@chill117 chill117 commented Sep 15, 2016

@fcarreiro Other than the one minor issue (dependency version), it looks great. Thanks!

@chill117 chill117 merged commit 96673bb into chill117:master Sep 15, 2016
1 check passed
@fcarreiro
Copy link
Contributor Author

@fcarreiro fcarreiro commented Sep 15, 2016

Great, thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants