New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mysql-connection-manager with a connection pool #51

Merged
merged 1 commit into from Sep 15, 2016

Conversation

2 participants
@fcarreiro
Contributor

fcarreiro commented Sep 9, 2016

Closes issue #50.

@fcarreiro

This comment has been minimized.

Contributor

fcarreiro commented Sep 13, 2016

@chill117 does this look kind of ok? ;)

@@ -19,7 +19,7 @@
"debug": "2.2.0",
"depd": "1.1.0",
"express-session": "1.14.0",
"mysql-connection-manager": "0.0.13"
"mysql": "^2.11.1"

This comment has been minimized.

@chill117

chill117 Sep 15, 2016

Owner

I prefer hard-coded/static version numbers for all dependencies.

@chill117

This comment has been minimized.

Owner

chill117 commented Sep 15, 2016

@fcarreiro Other than the one minor issue (dependency version), it looks great. Thanks!

@chill117 chill117 merged commit 96673bb into chill117:master Sep 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fcarreiro

This comment has been minimized.

Contributor

fcarreiro commented Sep 15, 2016

Great, thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment