Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPIR-V Parser lacking support for structures, and Constant-Creation Instructions #52

Closed
pvelesko opened this issue May 14, 2022 · 4 comments · Fixed by #479
Closed

SPIR-V Parser lacking support for structures, and Constant-Creation Instructions #52

pvelesko opened this issue May 14, 2022 · 4 comments · Fixed by #479
Milestone

Comments

@pvelesko
Copy link
Collaborator

Currently any Kokkos::HIP application segfaults during processing of a SPIR-V Structure.

    if (Opcode_ == spv::Op::OpTypeStruct) {
      size_t TotalSize = 0;
      for (size_t i = 2; i < WordCount_; ++i) {
        int32_t MemberId = OrigStream_[i];
        TotalSize += TypeMap[MemberId]->size();
      }
      return new SPIRVtypePOD(Word1_, TotalSize);
    }

Furthermore TypeMap does not contain all the POD sizes which causes a segfault.

@pjaaskel pjaaskel added this to the 1.0 milestone Mar 22, 2023
@pjaaskel
Copy link
Collaborator

This was likely fixed by #313, can you confirm?

@pvelesko pvelesko reopened this Mar 23, 2023
@pjaaskel
Copy link
Collaborator

pjaaskel commented Apr 4, 2023

Not fixed?

@pvelesko
Copy link
Collaborator Author

pvelesko commented Apr 4, 2023

Can't confirm yet as I ran into new issues while trying to build Kokkos.

@pjaaskel
Copy link
Collaborator

Is it still appearing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants