Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can dist zips have a branch name in them if they aren't on master? #86

Closed
adamwolf opened this issue Oct 2, 2015 · 8 comments
Closed

Comments

@adamwolf
Copy link
Contributor

adamwolf commented Oct 2, 2015

Hi Rick (and others),

My ant-fu is extremely weak.

  1. How hard would it be to get it so that dist zipfiles have the branch name in them, if the branch name isn't master?

  2. Does anyone else think this is a good idea?

Thanks!

@EmbeddedMan
Copy link
Member

Yeah, not only a good idea, a pretty critical one.

On Fri, Oct 2, 2015 at 11:15 AM, Adam Wolf notifications@github.com wrote:

Hi Rick (and others),

My ant-fu is extremely weak.

  1. How hard would it be to get it so that dist zipfiles have the branch
    name in them, if the branch name isn't master?

  2. Does anyone else think this is a good idea?

Thanks!


Reply to this email directly or view it on GitHub
#86.

@adamwolf
Copy link
Contributor Author

adamwolf commented Oct 5, 2015

Do we mind if it always has the branch name, or do we want it to only have the branch name in the zip if it isn't master?

@EmbeddedMan
Copy link
Member

I'm not opposed to every build including the branch name. I like the
consistency.

I do have to admit that I don't like the current build naming scheme much
because it does not include the piece of information that I need most of
all (other than the platform) which is the date on which it was built. I
have to get used to using the build number (16778041 in the filename below)
to know which one of several builds is the latest. We were used to doing it
with dates in the filenames, but that has changed.

Example: chipkit-core-windows.16778041.v1.0.0-21-g1c4b889.zip

*Brian

On Mon, Oct 5, 2015 at 8:57 AM, Adam Wolf notifications@github.com wrote:

Do we mind if it always has the branch name, or do we want it to only have
the branch name in the zip if it isn't master?


Reply to this email directly or view it on GitHub
#86 (comment)
.

@EmbeddedMan
Copy link
Member

Adam - what is the current status of this issue?
Rick - is there any reason to always put the branch name in the build (no matter if it's a real branch or master)?

@chipkitbot
Copy link

I was holding off on this until I knew if the weird zip issue was going to
come back. That's been fine for a while, and was only an issue on that one
branch. I can get tot his early this week.
On Oct 25, 2015 1:13 PM, "Brian Schmalz" notifications@github.com wrote:

Adam - what is the current status of this issue?
Rick - is there any reason to always put the branch name in the build (no
matter if it's a real branch or master)?


Reply to this email directly or view it on GitHub
#86 (comment)
.

@EmbeddedMan
Copy link
Member

Sweet. Thanks chipkitbot! You rock.

On Sun, Oct 25, 2015 at 1:45 PM, chipKIT Bot notifications@github.com
wrote:

I was holding off on this until I knew if the weird zip issue was going to
come back. That's been fine for a while, and was only an issue on that one
branch. I can get tot his early this week.
On Oct 25, 2015 1:13 PM, "Brian Schmalz" notifications@github.com wrote:

Adam - what is the current status of this issue?
Rick - is there any reason to always put the branch name in the build (no
matter if it's a real branch or master)?


Reply to this email directly or view it on GitHub
<
#86 (comment)

.


Reply to this email directly or view it on GitHub
#86 (comment)
.

@adamwolf
Copy link
Contributor Author

@EmbeddedMan Can you pull from my personal branch called branchname_in_tarballs and see what your dist zips show up as when you build on your desktop? It works on Jenkins, so now I need to make sure it works on a regular system.

@EmbeddedMan
Copy link
Member

I can confirm that it works for me locally under Windows. Pull the trigger!

*Brian

On Thu, Oct 29, 2015 at 1:05 PM, Adam Wolf notifications@github.com wrote:

@EmbeddedMan https://github.com/EmbeddedMan Can you pull from my
personal branch called branchname_in_tarballs and see what your dist zips
show up as when you build on your desktop? It works on Jenkins, so now I
need to make sure it works on a regular system.


Reply to this email directly or view it on GitHub
#86 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants