From ba98b86d418d53f19b5827cc83c53301f536add6 Mon Sep 17 00:00:00 2001
From: leorleor <leorleor@gmail.com>
Date: Wed, 2 May 2018 11:01:11 -0700
Subject: [PATCH] Update wiring_analog.c

Hi Jacob, thanks for writing this non-blocking analog read.  It is useful for me, even just as example code, because I am generating PWM signals and doing other time sensitive things on Arduinos.

What do you think of this code change?  It adds a line in the blocking analogRead so it can wait for an ongoing read to complete.  Was curious if you already considered this, as you mention hanging there as one of the few issues with the API.

Peace, Leor
---
 pic32/cores/pic32/wiring_analog.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/pic32/cores/pic32/wiring_analog.c b/pic32/cores/pic32/wiring_analog.c
index c25aa673..5eb99c7b 100644
--- a/pic32/cores/pic32/wiring_analog.c
+++ b/pic32/cores/pic32/wiring_analog.c
@@ -545,6 +545,9 @@ uint32_t analogReadConversion(){
 
 int analogRead(uint8_t pin)
 {
+  // In case a non-blocking read is in progress, wait for it to complete.
+  while( ! analogReadConversionComplete() );
+
   if (!analogReadConversionStart(pin)) return 0;
   while( ! analogReadConversionComplete() );
   return analogReadConversion();