Windows-style includes in Microchip libraries #146

Open
peplin opened this Issue Nov 23, 2011 · 5 comments

Comments

Projects
None yet
3 participants
@peplin

peplin commented Nov 23, 2011

A few of these were fixed already (http://chipkit.org/forum/viewtopic.php?f=7&t=416&start=10 thanks!) but one of my coworkers just discovered another, in chipKITUSBDevice.h:

#include "GenericTypeDefs.h"                                                     
#include "usb\usb_common.h"                                                      
#include "usb\usb_ch9.h"                                                         
#include "usb\usb_device.h"                                                      
#include "usb\usb_function_generic.h"                                            
#include "usb\usb_hal_pic32.h" 
@ricklon

This comment has been minimized.

Show comment Hide comment
@ricklon

ricklon Nov 28, 2011

Owner

I'll get this issue moving.

Owner

ricklon commented Nov 28, 2011

I'll get this issue moving.

@GeneApperson

This comment has been minimized.

Show comment Hide comment
@GeneApperson

GeneApperson Nov 28, 2011

Contributor

I believe that this has been fixed. The corrected version should be on the Digilent web site in the next day or so.

Contributor

GeneApperson commented Nov 28, 2011

I believe that this has been fixed. The corrected version should be on the Digilent web site in the next day or so.

@peplin

This comment has been minimized.

Show comment Hide comment
@peplin

peplin Aug 10, 2012

There are still some issues:


diff -wr foo/chipKITUSBDevice/utility/usb_device.c chipkit-libraries/chipKITUSBDevice/utility/usb_device.c
234c234
< #include "./USB/USB.h"
---
> #include "./USB/usb.h"

diff -wr foo/chipKITUSBDevice/USB/usb.h chipkit-libraries/chipKITUSBDevice/USB/usb.h
115,116c115,116
< #include "usb/usb_common.h"         // Common USB library definitions
< #include "usb/usb_ch9.h"            // USB device framework definitions
---
> #include "usb_common.h"         // Common USB library definitions
> #include "usb_ch9.h"            // USB device framework definitions
119c119
<     #include "usb/usb_device.h"     // USB Device abstraction layer interface
---
>     #include "usb_device.h"     // USB Device abstraction layer interface
123c123
<     #include "usb/usb_host.h"       // USB Host abstraction layer interface
---
>     #include "usb_host.h"       // USB Host abstraction layer interface
127c127
<     #include "usb/usb_otg.h" 
---
>     #include "usb_otg.h"
130c130
< #include "usb/usb_hal.h"            // Hardware Abstraction Layer interface
---
> #include "usb_hal.h"            // Hardware Abstraction Layer interface

There may others, too. It might be simplest if someone with access to the library source could just try and compile with it on a case sensitive platform like OS X or Linux.

peplin commented Aug 10, 2012

There are still some issues:


diff -wr foo/chipKITUSBDevice/utility/usb_device.c chipkit-libraries/chipKITUSBDevice/utility/usb_device.c
234c234
< #include "./USB/USB.h"
---
> #include "./USB/usb.h"

diff -wr foo/chipKITUSBDevice/USB/usb.h chipkit-libraries/chipKITUSBDevice/USB/usb.h
115,116c115,116
< #include "usb/usb_common.h"         // Common USB library definitions
< #include "usb/usb_ch9.h"            // USB device framework definitions
---
> #include "usb_common.h"         // Common USB library definitions
> #include "usb_ch9.h"            // USB device framework definitions
119c119
<     #include "usb/usb_device.h"     // USB Device abstraction layer interface
---
>     #include "usb_device.h"     // USB Device abstraction layer interface
123c123
<     #include "usb/usb_host.h"       // USB Host abstraction layer interface
---
>     #include "usb_host.h"       // USB Host abstraction layer interface
127c127
<     #include "usb/usb_otg.h" 
---
>     #include "usb_otg.h"
130c130
< #include "usb/usb_hal.h"            // Hardware Abstraction Layer interface
---
> #include "usb_hal.h"            // Hardware Abstraction Layer interface

There may others, too. It might be simplest if someone with access to the library source could just try and compile with it on a case sensitive platform like OS X or Linux.

@peplin

This comment has been minimized.

Show comment Hide comment
@peplin

peplin Nov 27, 2012

Is there any chance this can be patched? Every new person getting up to speed on my project runs into this problem, and since the libraries aren't open source I'm not able to just push a patched version to GitHub and have them just download that version.

peplin commented Nov 27, 2012

Is there any chance this can be patched? Every new person getting up to speed on my project runs into this problem, and since the libraries aren't open source I'm not able to just push a patched version to GitHub and have them just download that version.

@peplin

This comment has been minimized.

Show comment Hide comment
@peplin

peplin Sep 19, 2014

I'm revisiting this because I've been carrying these patches around for 2 years now, and I noticed a new version of the libraries at the Digilent site. Still broken! #199 is also still broken.

peplin commented Sep 19, 2014

I'm revisiting this because I've been carrying these patches around for 2 years now, and I noticed a new version of the libraries at the Digilent site. Still broken! #199 is also still broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment