Add support for emitting string-valued plusargs and plusargs with no default #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm but @seldridge is the contributor and primary user of |
jwright6323
changed the title
seldridge
suggested changes
May 8, 2020
|
Forgot to mention: Scaladoc for anything added in the PR would be good, too! |
seldridge
reviewed
May 8, 2020
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: other enhancement
Impact: API modification
Development Phase: implementation
I came across a case where I needed to add a plusarg in a BlackBoxed verilog module and found that I needed to use
PlusArgArtefacts.appendfor verilator to correctly parse my plusarg. This worked fine, but to get the help text to make sense I needed to add some features. This does change the API forPlusArgInfo, but other function calls are backwards compatible.