Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deb Packaging Updates #348

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@bladernr
Copy link

bladernr commented Feb 15, 2018

Updated version in debian/changelog to match source code version

  • When package was built, running chipsec failed because the dkms stuff was installed to a directory based on the package version (1.3.0) but the binary was looking in a directory called 1.3.5.

Updated debian/control to only build amd64

  • Because chipsec_tools/linux/: LzmaCompress.bin TianoCompress.bin
    are x86_64 binaries, there's no reason to build debs for anything else.

Jeff Lane added some commits Feb 15, 2018

Jeff Lane
debian/changelog: version bump to match source code version. debian/c…
…ontrol: modified to only build amd64 and i386 arches
@abazhaniuk

This comment has been minimized.

Copy link
Contributor

abazhaniuk commented Feb 18, 2018

chipsec supports x86 and x86_64 systems...

@@ -7,14 +7,14 @@ Standards-Version: 3.9.1
Homepage: https://github.com/chipsec/chipsec

Package: chipsec
Architecture: any
Architecture: amd64

This comment has been minimized.

Copy link
@abazhaniuk

abazhaniuk Feb 18, 2018

Contributor

i think chipsec support x86 system too.

This comment has been minimized.

Copy link
@bladernr

bladernr Feb 19, 2018

Author

Chipsec will run on x86 if I build it locally. But when building debs so far, I've yet to get it to work. Even setting Architecture to All fails because at the end of the day, it's just installing a 64bit binary on a 32bit system (the binaries in chipsec_tools/linux are 64bit binaries). This is the result of that attempt:

root@ubuntu-s-2vcpu-4gb-nyc3-01:~# chipsec_main
Traceback (most recent call last):
File "/usr/bin/chipsec_main", line 9, in
load_entry_point('chipsec==1.3.5', 'console_scripts', 'chipsec_main')()
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 542, in load_entry_point
return get_distribution(dist).load_entry_point(group, name)
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 2569, in load_entry_point
return ep.load()
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 2229, in load
return self.resolve()
File "/usr/lib/python2.7/dist-packages/pkg_resources/init.py", line 2235, in resolve
module = import(self.module_name, fromlist=['name'], level=0)
File "/usr/lib/python2.7/dist-packages/chipsec_main.py", line 56, in
import chipsec.module
File "/usr/lib/python2.7/dist-packages/chipsec/module.py", line 27, in
from chipsec.module_common import ModuleResult
File "/usr/lib/python2.7/dist-packages/chipsec/module_common.py", line 43, in
import chipsec.chipset
File "/usr/lib/python2.7/dist-packages/chipsec/chipset.py", line 41, in
from chipsec.helper.oshelper import OsHelper, OsHelperError
File "/usr/lib/python2.7/dist-packages/chipsec/helper/oshelper.py", line 93, in
import chipsec.helper.helpers
File "/usr/lib/python2.7/dist-packages/chipsec/helper/helpers.py", line 26, in
from chipsec.helper.linux import *
File "/usr/lib/python2.7/dist-packages/chipsec/helper/linux/helper.py", line 56, in
from chipsec_tools import efi_compressor
ImportError: /usr/lib/python2.7/dist-packages/chipsec_tools/efi_compressor.so: wrong ELF class: ELFCLASS64

So maybe there's a way to fix that in deb packaging, but I'm no packaging expert, and to be honest, I don't really have the time to devote to fixing this at that level. I do agree this is not the best solution though, so please do feel free to reject the PR.

@ErikBjorge

This comment has been minimized.

Copy link
Member

ErikBjorge commented Feb 21, 2018

@abazhaniuk do you see a problem just supporting X64 builds for now and debugging the X86 issue later? Do you have any other guidance for a solution to this problem?

@johnloucaides

This comment has been minimized.

Copy link
Member

johnloucaides commented Feb 21, 2018

Based on the above, I'm thinking this is because we checked in binaries for decompression and we're not automatically compiling them.

@abazhaniuk

This comment has been minimized.

Copy link
Contributor

abazhaniuk commented Feb 22, 2018

btw, chipsec_tools/linux/ - is legacy and should not be used by chipsec...

@ErikBjorge

This comment has been minimized.

Copy link
Member

ErikBjorge commented Feb 26, 2018

Does anyone (@abazhaniuk or @johnloucaides) see a problem with merging this change with amd64 support for now and figuring out why building x86 has an issue later?

@johnloucaides

This comment has been minimized.

Copy link
Member

johnloucaides commented Mar 6, 2018

Sounds ok to me.

@abazhaniuk abazhaniuk referenced this pull request Mar 16, 2018

Merged

deb package fixed #370

@abazhaniuk

This comment has been minimized.

Copy link
Contributor

abazhaniuk commented Mar 17, 2018

added fix at: #370

@abazhaniuk abazhaniuk closed this Mar 17, 2018

meghadey pushed a commit to intel/luv-yocto that referenced this pull request Dec 18, 2018

chipsec: Stop removing unnecessary files for 32-bit x86 builds
In CHIPSEC pull request chipsec/chipsec#348, all
files under chipsec_tools/linux were removed as part of a cleanup. These
files were legacy and should not be used.

Reported-by: Megha Dey <megha.dey@linux.intel.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>

meghadey pushed a commit to intel/luv-yocto that referenced this pull request Dec 18, 2018

chipsec: Stop removing unnecessary files for 32-bit x86 builds
In CHIPSEC pull request chipsec/chipsec#348, all
files under chipsec_tools/linux were removed as part of a cleanup. These
files were legacy and should not be used.

Reported-by: Megha Dey <megha.dey@linux.intel.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>

meghadey pushed a commit to intel/luv-yocto that referenced this pull request Dec 19, 2018

chipsec: Stop removing unnecessary files for 32-bit x86 builds
In CHIPSEC pull request chipsec/chipsec#348, all
files under chipsec_tools/linux were removed as part of a cleanup. These
files were legacy and should not be used.

Reported-by: Megha Dey <megha.dey@linux.intel.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Signed-off-by: Megha Dey <megha.dey@linux.intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.