Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding of S3 bootscript EDKCompat opcodes #737

merged 1 commit into from Nov 7, 2019


Copy link

gch1p commented Oct 30, 2019

Decoded opcodes were not returned from the function.
Was broken since 2efeda4. Bad merge, apparently.

Signed-off-by: Evgeny Zinoviev

Signed-off-by: Evgeny Zinoviev <>

This comment has been minimized.

Copy link

lgtm-com bot commented Oct 30, 2019

This pull request fixes 8 alerts when merging f92572f into 3354a4e - view on

fixed alerts:

  • 7 for Unused local variable
  • 1 for Use of the return value of a procedure

This comment has been minimized.

Copy link

gch1p commented Oct 30, 2019

s3 bootscript patching is also broken by the way. I'll look at it closer and send another PR.

@BrentHoltsclaw BrentHoltsclaw merged commit b77607a into chipsec:master Nov 7, 2019
1 check passed
1 check passed
LGTM analysis: Python 8 fixed alerts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.