Repository navigation
TLS Support by Reverse-Proxy for Basicstation - #241
Merged
Merged
Conversation
1 task done
|
Why is this pull request not accepted yet? is there any issue? this gives a very much needed feature. |
|
Hi @brocaar , I am currently using https://github.com/chirpstack/chirpstack-docker and noticed that the docker image it's using for the gateway bridge which is https://hub.docker.com/r/chirpstack/chirpstack-gateway-bridge, is not up to date with these current changes. Would be great to see this one implemented on the main image |
|
Hi @brocaar , I would love to see the chirpstack-gateway-bridge docker to be updated with this fix as it currently blocking us to go live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the feature request #240, I implemented a way of handling a TLS Server Authentication when using a reverse-proxy like traefik or nginx.
I've made sure that this feature doesn't cause any compatibility problems with previous versions. This means that if TLS certificates are referenced, TLS will be enabled by default on the gateway-bridge, as it used to be.