Skip to content

[easy] Http Integration multiple URLs separator mistake #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RodionGork opened this issue Nov 17, 2022 · 2 comments
Closed

[easy] Http Integration multiple URLs separator mistake #62

RodionGork opened this issue Nov 17, 2022 · 2 comments

Comments

@RodionGork
Copy link

For integration (streaming events) via HTTP multiple urls could be specified.

In the code they are split with whitespace:

https://github.com/chirpstack/chirpstack/blob/master/chirpstack/src/integration/http.rs#L22

But the hint in the UI for this input field insists it should be comma!

https://github.com/chirpstack/chirpstack/blob/master/ui/src/views/applications/integrations/HttpIntegrationForm.tsx#L46

I would gladly create PR myself but I don't know which way you prefer it to be fixed - either change the code to use comma (slight probability to break some running installation) - or to change the tooltip. I guess the code fix is better as it doesn't make good logic with further whitespace removal.

@sagar-patel-sls
Copy link
Contributor

@RodionGork

I think code fixing (changing the code to use comma) is better than changing the tooltip.

Thanks

@brocaar
Copy link
Contributor

brocaar commented Nov 17, 2022

Hi @RodionGork, good spot. This indeed should have been split by ',', not whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants