Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Test fixes for 04.trace.t #1

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

felliott commented Mar 7, 2012

Hello!

Attached are two patches for your consideration:

1.) Catayst::Plugin::ErrorCatcher HEAD fails a test on my system. The last test in 04.trace.t, "'evil' has value 'two\nlines' in QUERY section", fails because HTTP::Request::Common::POST converts the \n to \r\n. Included is a simple patch that fixes that test.

2.) This is not a failing test, but when _has_param_section() is called with a BODY type, it was printing the test name as "QUERY params block exists".

All tests pass with Catalyst 5.90007. Unfortunately, Catalyst >=5.90008 has a bug that causes all the BODY tests to fail, which I've reported to RT.

Thank you for writing this module. I'm looking forward to using this in my application; I think it will come in really handy!

Cheers,
Fitz Elliott

I wonder if that should be '\r?' to not break it for existing/older versions.

Owner

felliott replied Mar 8, 2012

Owner

chiselwright commented Mar 8, 2012

Resolved with pull #2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment