New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Added missing META.json file. [PRC] #5

Merged
merged 2 commits into from Jan 2, 2016

Conversation

Projects
None yet
2 participants
@manwar
Contributor

manwar commented Jan 1, 2016

Hi Chisel, please review the above change as a part of PR challenge 2016.

Many Thanks.
Best Regards,
Mohammad S Anwar

@chiselwright

This comment has been minimized.

Show comment
Hide comment
@chiselwright

chiselwright Jan 2, 2016

Owner

Thanks for picking this up and submitting the pull-request. Sorry to be niggly but would it be possible for you to:

  • move the [...] higher up in dist.ini
  • make the commit summary present tense
    • I think it would be more accurate to say 'Generate missing...'
  • add the commit summary to the Changes file
    • 0839f7c is an example of how to do this if you are unfamiliar

I realise I could easily make these changes myself, but when I update the module to automatically generate contributors (from commit history) I'd like you to appear in that list to reflect your contribution.

Owner

chiselwright commented Jan 2, 2016

Thanks for picking this up and submitting the pull-request. Sorry to be niggly but would it be possible for you to:

  • move the [...] higher up in dist.ini
  • make the commit summary present tense
    • I think it would be more accurate to say 'Generate missing...'
  • add the commit summary to the Changes file
    • 0839f7c is an example of how to do this if you are unfamiliar

I realise I could easily make these changes myself, but when I update the module to automatically generate contributors (from commit history) I'd like you to appear in that list to reflect your contribution.

@manwar

This comment has been minimized.

Show comment
Hide comment
@manwar

manwar Jan 2, 2016

Contributor

Hi Chisel, I pushed another commit as below as per your suggestions.

manwar@9abe764

Best Regards,
Mohammad S Anwar

Contributor

manwar commented Jan 2, 2016

Hi Chisel, I pushed another commit as below as per your suggestions.

manwar@9abe764

Best Regards,
Mohammad S Anwar

chiselwright added a commit that referenced this pull request Jan 2, 2016

Merge pull request #5 from Manwar/add-missing-meta-json
- Added missing META.json file. [PRC]

@chiselwright chiselwright merged commit c92acb8 into chiselwright:master Jan 2, 2016

@chiselwright

This comment has been minimized.

Show comment
Hide comment
@chiselwright

chiselwright Jan 2, 2016

Owner

Brilliant. Thank you.

Owner

chiselwright commented Jan 2, 2016

Brilliant. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment