New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace content_[un]like regexps with grep_inputs #1

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@kyzn
Contributor

kyzn commented Oct 3, 2016

Tests were failing due to regexp not matching the order.
For example, we expect to have name and then type,
but we get type and then name, which shouldn't be a big
problem, but it makes tests fail. Using grep_inputs and
seeing if there is a field with given properties fixes
the problem, and tests pass just fine.

cpanpr #hacktoberfest

Replace content_[un]like regexps with grep_inputs
Tests were failing due to regexp not matching the order.
For example, we expect to have name and then type,
but we get type and then name, which shouldn't be a big
problem, but it makes tests fail. Using grep_inputs and
seeing if there is a field with given properties fixes
the problem, and tests pass just fine.

@chiselwright chiselwright merged commit 79a5fd2 into chiselwright:master Oct 4, 2016

chiselwright added a commit that referenced this pull request Oct 4, 2016

v0.0.1
 - replace content_[un]like regexps with grep_inputs #1
 - update dist.ini to require ALL the Test reqs
 - include submodule for buildkite helpers
 - include Pod::Weaver::Section::Contributors
@chiselwright

This comment has been minimized.

Show comment
Hide comment
@chiselwright

chiselwright Oct 4, 2016

Owner

Uploaded to CPAN as Catalyst-Controller-Validation-DFV-0.0.9.tar.gz

Owner

chiselwright commented Oct 4, 2016

Uploaded to CPAN as Catalyst-Controller-Validation-DFV-0.0.9.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment