New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove perl shebang line in test scripts #13

Merged
merged 1 commit into from Nov 1, 2015

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Nov 1, 2015

The test scripts aren't executable, and they should be run either through
perl or as part of a dzil test run, hence it isn't necessary to use a
shebang line.

@chiselwright

This comment has been minimized.

Owner

chiselwright commented Nov 1, 2015

I'm unable to merge this one; I'm stuck on my phone approving these tonight.

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Nov 1, 2015

No worries, I'll merge the code, fix the conflicts and re-submit the PR.

Remove perl shebang line in test scripts
The test scripts aren't executable, and they should be run either through
`perl` or as part of a `dzil test` run, hence it isn't necessary to use a
shebang line.

@paultcochrane paultcochrane deleted the paultcochrane:pr/remove-shebang-in-tests branch Nov 1, 2015

@paultcochrane paultcochrane restored the paultcochrane:pr/remove-shebang-in-tests branch Nov 1, 2015

@paultcochrane

This comment has been minimized.

Contributor

paultcochrane commented Nov 1, 2015

Hrm, it seems I completely screwed up the merge and force update. Really, the last commit (9793d3a) is the one you want. Sorry about the muddle!

@paultcochrane paultcochrane reopened this Nov 1, 2015

chiselwright added a commit that referenced this pull request Nov 1, 2015

@chiselwright chiselwright merged commit a17ab74 into chiselwright:master Nov 1, 2015

chiselwright added a commit that referenced this pull request Nov 15, 2015

v0.0.5
 - Merged pull-requests from Paul Cochrane:
   - #6 replace NoTabsTests
   - #7 add missing abstracts (for dzil)
   - #8 add Travis config
   - #9 purge trailing whitespace
   - #10 fix POD errors
   - #11 update dist.ini
   - #12 add missing strictures
   - #13 remove shebang in tests
   - #14 fix typos in POD
   - #15 fix tests on non-English locales
   - #16 increase error severity in call handler
 - Resolve "[PkgVersion] no blank line for $VERSION after package" with dzil prep
 - add skeleton POD for methods
   unhelpfully empty but keeps pod-coverage tests happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment