Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase coverage to more than 50% #117

Merged
merged 1 commit into from Apr 26, 2020
Merged

Conversation

kayoub5
Copy link
Collaborator

@kayoub5 kayoub5 commented Apr 24, 2020

No description provided.

@chmorgan chmorgan closed this Apr 24, 2020
@chmorgan chmorgan reopened this Apr 24, 2020
Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why the ci tests are failing?

Test/DeviceFixture.cs Outdated Show resolved Hide resolved
Test/DeviceFixture.cs Outdated Show resolved Hide resolved
@kayoub5 kayoub5 force-pushed the coverage/get_above_50 branch 3 times, most recently from 5bec332 to b6827b3 Compare April 24, 2020 21:00
@kayoub5 kayoub5 requested a review from chmorgan April 24, 2020 22:26
@codecov-io
Copy link

codecov-io commented Apr 24, 2020

Codecov Report

Merging #117 into master will increase coverage by 4.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   49.97%   54.68%   +4.70%     
==========================================
  Files          43       43              
  Lines        2443     2443              
  Branches      310      310              
==========================================
+ Hits         1221     1336     +115     
+ Misses       1154     1034     -120     
- Partials       68       73       +5     
Flag Coverage Δ
#linux ?
#windows 48.46% <ø> (+4.91%) ⬆️
Impacted Files Coverage Δ
SharpPcap/LibPcap/PcapHeader.cs 67.39% <0.00%> (-23.92%) ⬇️
SharpPcap/LibPcap/Sockaddr.cs 75.00% <0.00%> (-20.32%) ⬇️
SharpPcap/LibPcap/PcapInterface.cs 84.07% <0.00%> (-4.43%) ⬇️
SharpPcap/Npcap/NpcapDevice.cs 21.66% <0.00%> (+0.83%) ⬆️
SharpPcap/LibPcap/PcapDeviceCaptureLoop.cs 53.64% <0.00%> (+2.64%) ⬆️
SharpPcap/Npcap/NpcapDeviceList.cs 76.22% <0.00%> (+9.83%) ⬆️
SharpPcap/LibPcap/LibPcapLiveDeviceList.cs 74.44% <0.00%> (+13.33%) ⬆️
SharpPcap/WinPcap/WinPcapDevice.cs 15.83% <0.00%> (+15.83%) ⬆️
SharpPcap/CaptureDeviceList.cs 48.80% <0.00%> (+48.80%) ⬆️
SharpPcap/WinPcap/WinPcapDeviceList.cs 49.18% <0.00%> (+49.18%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b78024a...b6827b3. Read the comment docs.

Copy link
Collaborator

@chmorgan chmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments. CI looks like its passing now. Not sure what was up before.

@kayoub5 kayoub5 requested a review from chmorgan April 26, 2020 10:33
@chmorgan chmorgan merged commit 734f852 into master Apr 26, 2020
@kayoub5 kayoub5 deleted the coverage/get_above_50 branch April 26, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants