escape_path (URI escape rather than CGI escape)

leahneukirchen · May 3, 2011 · 3e9c822 · 3e9c822
1 parent 9134176
commit 3e9c822
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rack/utils.rb b/lib/rack/utils.rb
@@ -18,12 +18,19 @@ module Rack
   # applications adopted from all kinds of Ruby libraries.
 
   module Utils
-    # URI escapes a string.
+    # URI escapes a string. (CGI style space to +)
     def escape(s)
       CGI.escape(s.to_s)
     end
     module_function :escape
 
+    # Like URI escaping, but with %20 instead of +. Strictly speaking this is
+    # true URI escaping.
+    def escape_path(s)
+      escape(s).gsub('+', '%20')
+    end
+    module_function :escape_path
+
     # Unescapes a URI escaped string.
     def unescape(s)
       CGI.unescape(s)

diff --git a/test/spec_utils.rb b/test/spec_utils.rb
@@ -26,6 +26,10 @@
     end
   end
 
+  should "escape path spaces with %20" do
+    Rack::Utils.escape_path("foo bar").should.equal  "foo%20bar"
+  end
+
   should "unescape correctly" do
     Rack::Utils.unescape("fo%3Co%3Ebar").should.equal "fo<o>bar"
     Rack::Utils.unescape("a+space").should.equal "a space"