Make Rack::File use RFC 2616 HTTP Date/Time format for Last-Modified

leahneukirchen · Jun 27, 2008 · 7523300 · 7523300
1 parent 2e3c3ad
commit 7523300
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/rack/file.rb b/lib/rack/file.rb
@@ -31,7 +31,7 @@ def _call(env)
 
       if F.file?(@path) && F.readable?(@path)
         [200, {
-           "Last-Modified"  => F.mtime(@path).rfc822,
+           "Last-Modified"  => F.mtime(@path).httpdate,
            "Content-Type"   => MIME_TYPES[ext] || "text/plain",
            "Content-Length" => F.size(@path).to_s
          }, self]

diff --git a/test/spec_rack_file.rb b/test/spec_rack_file.rb
@@ -15,7 +15,17 @@
     res.should.be.ok
     res.should =~ /ruby/
   end
-
+
+  specify "sets Last-Modified header" do
+    res = Rack::MockRequest.new(Rack::Lint.new(Rack::File.new(DOCROOT))).
+      get("/cgi/test")
+
+    path = File.join(DOCROOT, "/cgi/test")
+
+    res.should.be.ok
+    res["Last-Modified"].should.equal File.mtime(path).httpdate
+  end
+
   specify "serves files with URL encoded filenames" do
     res = Rack::MockRequest.new(Rack::Lint.new(Rack::File.new(DOCROOT))).
       get("/cgi/%74%65%73%74") # "/cgi/test"