New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed on leap year #2

Closed
adhisimon opened this Issue Feb 29, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@adhisimon

adhisimon commented Feb 29, 2016

require('micro-strptime').strptime('29/Feb/2016:09:00:00 +0700', '%d/%B/%Y:%H:%M:%S %Z');

It return

Tue Mar 01 2016 09:00:00 GMT+0700 (WIB)

Should return
Mon Feb 29 2016 09:00:00 GMT+0700 (WIB)

pineapplemachine added a commit to pineapplemachine/micro-strptime.js that referenced this issue May 16, 2018

pineapplemachine added a commit to pineapplemachine/micro-strptime.js that referenced this issue May 16, 2018

Update tests and add test case for cho45#2
Add a test case for Feb 29 in a timestamp
Changes to assert.throws calls were needed to run with node v10 (the assert dependency has been updated since then)
Added a couple extra console log lines to help me debug

@cho45 cho45 closed this in #3 May 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment