Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Make travis report test failure since make test didn't report exit code #23

Merged
merged 1 commit into from almost 2 years ago

2 participants

Reeze Xia Shuhei Tanuma
Reeze Xia
reeze commented July 15, 2012

Hi, chobie,

make test didn't report exit code properly, even make test failed, travis will not complain.

please refer:
https://github.com/reeze/php-leveldb/blob/master/travis/run-test.sh
https://bugs.php.net/bug.php?id=60285

Look at this one, test failed but reported sucess
http://travis-ci.org/#!/reeze/php-sundown/jobs/1670528

if test failed, cat will output the diffs, it will help us debugging :)

Thanks

Shuhei Tanuma chobie merged commit b0adcc7 into from July 15, 2012
Shuhei Tanuma chobie closed this July 15, 2012
Shuhei Tanuma
Owner
chobie commented July 15, 2012

thanks @reeze. I didin't know that.

probably we should use phpunit as it can test on windows box. I'll add it to next release.

Reeze Xia
reeze commented July 15, 2012

thanks for quick repsonse :)

run-tests.php could run on windows too. do you Rakefile stuff?

Shuhei Tanuma
Owner
chobie commented July 15, 2012

run-tests.php could run on windows too.

really? I also don't know this. I guess phpunit is easier than run-tests.php. I'll test it later.

do you Rakefile stuff?

nope. redcarpet uses Rakefile so I just use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 1 deletion. Show diff stats Hide diff stats

  1. 2  Rakefile
2  Rakefile
... ...
@@ -1,4 +1,3 @@
1  
-
2 1
 desc "compile php-sundown"
3 2
 task :compile => ['sundown/src/markdown.h'] do
4 3
 	sh "phpize"
@@ -19,6 +18,7 @@ desc "run php test cases"
19 18
 task :test do
20 19
 	ENV["TESTS"] = "--show-diff -q"
21 20
 	sh "make test"
  21
+	sh "cat tests/*.diff; if [ $? -eq 0 ];then exit 1; fi"
22 22
 end
23 23
 
24 24
 desc "Run conformance tests"
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.