Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First-class support for Freedoom single player IWADs #1210

Merged
merged 4 commits into from Nov 5, 2019

Conversation

@fragglet
Copy link
Member

fragglet commented Nov 3, 2019

Recent Freedoom releases are (90+% at least) vanilla compatible so let's go ahead and mark them as supported.

fragglet added 4 commits Nov 3, 2019
The Freedoom project some time back set a goal that the project's
single player levels would become vanilla-compatible. This goal has
now been mostly achieved, so that most levels are now playable with
Chocolate Doom. So add the freedoom1/2 IWADs to the macOS launcher.
We previously discouraged use of the Freedoom single-player IWADs
because they were not yet vanilla-compatible and could lead to a bad
experience with Chocolate Doom. This is no longer the case since the
project has converted its levels to be vanilla compatible with
recent releases.
We have been displaying this warning because older versions of the
Freedoom IWADs were not vanilla-compatible, but this is no longer
the case.
FreeDM is more of a niche IWAD, and there's no reason any more that
we should pick it over the main Freedoom IWAD files.
@chungy

This comment has been minimized.

Copy link
Contributor

chungy commented Nov 4, 2019

Seems all good to me, and appropriate too (might have possibly been considered with Freedoom 0.11, but we didn't actually have an official stance on the vanilla-ness yet).

@fabiangreffrath

This comment has been minimized.

Copy link
Member

fabiangreffrath commented Nov 5, 2019

Good idea to move freedoom before freedm priority wise!

@fragglet fragglet merged commit e1cc501 into master Nov 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fragglet

This comment has been minimized.

Copy link
Member Author

fragglet commented Nov 5, 2019

Thanks folks. I also updated the wiki page; it's a lot briefer now.

@fabiangreffrath

This comment has been minimized.

Copy link
Member

fabiangreffrath commented on 7d724dd Nov 18, 2019

@fragglet do you still need this branch around?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.