Skip to content
This repository has been archived by the owner. It is now read-only.

Write-FileUpdateLog fails when $binRoot set to C:\ #434

Closed
bill-long opened this issue Mar 5, 2014 · 2 comments

Comments

@bill-long
Copy link
Contributor

commented Mar 5, 2014

If %ChocolateyBinRoot% has been set to the root of the systemdrive (which can happen unintentionally as a result of the bug described in #421), Write-FileUpdateLog produces a large number of exceptions as it tries to recurse every folder on the drive. Those errors are documented in #430, for example.

After #421 is merged to prevent future installs from unintentionally setting the bin root to the systemdrive root, one of the two following options needs to happen:

  • We need to add code that detects if $binRoot has been set to the systemdrive root and change it to the default of \tools. This means Chocolatey would not support setting bin root to systemdrive root, even if it was intentional.

or

  • We need to fix Write-FileUpdateLog so that it works even if it cannot recurse all folders under the bin root. This would allow users to set their bin root to systemdrive root if desired.
@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented May 31, 2014

We went with the fix of not allowing c:\ for now.

@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented May 31, 2014

See cd11749

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.