Skip to content
This repository has been archived by the owner. It is now read-only.

[BUG] Working directory of shimgen generated files points to path target executable is in (GUI apps only) #508

Closed
kevinsawicki opened this issue Jul 9, 2014 · 4 comments

Comments

@kevinsawicki
Copy link

commented Jul 9, 2014

I'm noticing that the working directory of applications created by shimgen seems to be the path that the target executable is in, not the path that the executable was launched from.

So if an application takes arguments that are relative paths, when they are resolved against the working directory they will be resolved against the location of the application, not the directory where the command was run.

Is this intended behavior and is there any workaround to access the original working directory where the command was run from?

@ferventcoder ferventcoder added the shimgen label Jul 9, 2014
@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2014

Nope, let's call this a bug.

@ferventcoder ferventcoder changed the title Working directory of shimgen generated files [BUG] Working directory of shimgen generated files points to path target executable is in Jul 9, 2014
@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2014

Also #509

@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2014

This seems to only be on GUI applications :(

ferventcoder added a commit that referenced this issue Jul 11, 2014
 - Shimgen no longer changes the working directory to target files (this only
   occurred for GUI apps)
 - Adding --shimgen-log to the end of a shim call command will cause the shim
   to log to the console information about what it is doing
 - Adding --shimgen-usetargetworkingdirectory to the end of a shim call will
   cause it to use the target executable's working directory instead of the
   current work directory.
ferventcoder added a commit that referenced this issue Jul 11, 2014
* stable:
  (GH-508)(GH-509) shimgen fix/improvements
@ferventcoder ferventcoder changed the title [BUG] Working directory of shimgen generated files points to path target executable is in [BUG] Working directory of shimgen generated files points to path target executable is in (GUI apps only) Jul 11, 2014
@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2014

@kevinsawicki I pushed a prerelease package with the fixes. Can you install chocolatey prerelease and then reinstall atom to regenerate the shim? Or have the person who reported the issue do this... :)

choco install chocolatey -pre
choco install atom -f

Then try the issue reported again to see if it also working for you now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.