Skip to content
This repository has been archived by the owner. It is now read-only.

Improved Remove-BinFile to remove shim .exes when uninstalling a package #449

Conversation

@jberezanski
Copy link
Contributor

commented Mar 31, 2014

Until now, Remove-BinFile only knew about the old-method batch redirects, so shimgen-generated exes were left behind.

Additionally, print messages about nonexistent batch redirects only in
debug mode. Remove-BinFile does not know which method was used to create
the redirects and the messages are false positives if shimgen was used.
Besides, those messages are useless to the end user anyway.
@ferventcoder ferventcoder self-assigned this Mar 31, 2014
@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented May 28, 2014

@jberezanski Would you rebase this against stable instead? That way I can get it pulled in easier. If not I can make it happen soon.

@jberezanski

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2014

Done as GH-480, since existing PRs apparently cannot be retargeted.

Should all PRs be sent against stable by default? It would be helpful to mention it in CONTRIBUTING.md if that's the case.

@ferventcoder

This comment has been minimized.

Copy link
Contributor

commented May 31, 2014

All PRs should be targeted against master. I think we have that listed in contributing? I was just asking because I planned to pull this in and if you wanted to hook it up, it would save me a few moments ;)

@jberezanski

This comment has been minimized.

Copy link
Contributor Author

commented Jun 3, 2014

The guidelines did not specify a target branch, but here's a PR :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.