Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File description of ShimGen shims should match original as closely as possible #374

Closed
alexchandel opened this issue Jul 30, 2015 · 10 comments

Comments

@alexchandel
Copy link

commented Jul 30, 2015

Currently, although ShimGen does (usually) successfully get the icon, the file description is left "ShimGen generated shim" with author "RealDimensions Software, LLC". This is bad, because I can't make shortcuts to these. If I do, and I open a file with them, then Windows Explorer calls every single file of that type "ShimGen generated shim". Which just doesn't work for .7z files.

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Jul 30, 2015

Interesting, what makes it weird for 7z?

@alexchandel

This comment has been minimized.

Copy link
Author

commented Jul 30, 2015

@ferventcoder lol only the order of magnitude: I have lots of 7z/LZMA archives. Plus 7zip has all its file associations, so if I right click pretty much any zip or image, I saw the default option is to open it with ShimGen generated shim.

This originates from me creating shortcuts for most of the GUI programs in chocolatey/bin and sticking them in C:\ProgramData\Microsoft\Windows\Start Menu\Programs for easy access, only to discover that the start menu was full of ShimGen generated shim. Which was even more hilarious with Win10's giant tiles.

The workaround is to "shortcut" directly to the binary in chocolatey/lib/foo, but that doesn't always work, since there are a few packages whose subfolders change with versions (e.g. filezilla). And I feel like I'm defeating the purpose of my awesome common bin folder by doing that

@alexchandel

This comment has been minimized.

Copy link
Author

commented Jul 30, 2015

It might be worth it to scrape the "Author"/"File version"/"Product name"/"Product version" keys as well, since those seem to be used in some places, and currently incorrectly refer to ShimGen's details.

If it's possible we could add a custom key like "ShimGen target" for informational purposes, which would also mark the exe as a ShimGen product.

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Jul 30, 2015

@alexchandel you mean pull that information out of the file itself if we find it? Sounds like a good enhancement.

@alexchandel

This comment has been minimized.

Copy link
Author

commented Aug 20, 2015

@ferventcoder How can we go about changing the behavior of shimgen?

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Aug 20, 2015

If you know how to get to the file information, it would be good to note that in this ticket (or shimgen 17).

@aronovgj

This comment has been minimized.

Copy link
Member

commented Aug 20, 2015

@ferventcoder ferventcoder added this to the 0.9.10.x milestone Dec 17, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.10.x Feb 13, 2016
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Feb 13, 2016

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Feb 13, 2016

This has been completed.

@ferventcoder

This comment has been minimized.

Copy link
Member

commented Feb 13, 2016

Once it gets pulled in I will close this issue.

@ferventcoder ferventcoder added 3 - Done and removed 0 - Backlog labels Feb 13, 2016
ferventcoder added a commit that referenced this issue Feb 15, 2016
- Shim Generation automatically detects GUI
- Shims now contain most of the original information from the original
executable.
ferventcoder added a commit that referenced this issue Feb 15, 2016
* stable:
  (GH-604) Licensed source - ensure config exists
  (maint) Update Choco Shims
  (GH-374)(GH-634) shimgen updates
@ferventcoder ferventcoder self-assigned this Feb 29, 2016
ferventcoder added a commit to ferventcoder/choco that referenced this issue Feb 29, 2016
- Fixes shimgen removing multiple spaces in arguments
- Makes detection of shimgen arguments more deterministic, so false
   positives are not also removed
- Use icon path for file information path if the file path doesn't
   exist.
ferventcoder added a commit that referenced this issue Mar 2, 2016
* stable:
  (GH-649) Write Small File When Download Type Text
  (GH-647)(GH-374) Update shimgen.exe
  (maint) update redirect shims
@ferventcoder ferventcoder changed the title Fix file description of ShimGen shims File description of ShimGen shims should match original as closely as possible Mar 11, 2016
ferventcoder added a commit that referenced this issue Mar 11, 2016
Shimgen took a dependency on something that was super heavyweight (it
increased the size by almost 8 times!) and was later found to be
completely unnecessary. Switched it over to using built-in libraries
and the size is back to what it was but still able to provide the same
features as the larger binary did.
ferventcoder added a commit that referenced this issue Mar 11, 2016
* stable:
  (doc) update Changelog/nuspec
  (GH-258) File detector use exe
  (GH-658) Allow custom key/value args in choco new
  (GH-641) log file is optional
  (maint) ANYCPU all the things
  (GH647)(GH-374) Update shimgem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.