Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the actual download file name instead of providing one #435

Closed
aronovgj opened this issue Sep 27, 2015 · 4 comments

Comments

@aronovgj
Copy link
Member

commented Sep 27, 2015

Installers might not like being renamed to packagenameInstall.exe when being downloaded to temporary folder. MiKTeX for example failed to install with a differently named installer.

Migrated from chocolatey-archive/chocolatey#538

@ferventcoder ferventcoder added this to the 0.9.9.9 milestone Sep 28, 2015
@ferventcoder ferventcoder self-assigned this Sep 28, 2015
@ferventcoder ferventcoder changed the title Don't rename setup files after download Use the actual download file name instead of providing one Sep 30, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.9.9, 0.9.10.1 Sep 30, 2015
@ferventcoder ferventcoder modified the milestones: 0.9.10, 0.9.10.1 Dec 23, 2015
@ferventcoder ferventcoder added 3 - Done and removed 0 - Backlog labels Jan 28, 2016
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Jan 28, 2016

MSIs also hate it.

ferventcoder added a commit that referenced this issue Jan 28, 2016
When possible, use the original download file name. Some installers,
especially some MSI installers don't like to be renamed and do not
function properly when they are renamed. Use the original name so that
everything works appropriately.
ferventcoder added a commit that referenced this issue Jan 28, 2016
* stable:
  (GH-435) Use Original Download File Name
  (GH-332) Fixup example
@ferventcoder

This comment has been minimized.

Copy link
Member

commented Jan 28, 2016

You and @DarwinJS will be so happy to see this fixed.

@DarwinJS

This comment has been minimized.

Copy link

commented Jan 28, 2016

Awesome!

@aronovgj

This comment has been minimized.

Copy link
Member Author

commented Jan 28, 2016

I will be happy to see it in the stable so that I can change the miktex package. Or I'll just leave it as it is. Doesn't hurt anyone after all.

ferventcoder added a commit to ferventcoder/choco that referenced this issue Apr 22, 2016
- If the url is null, return the default file name.
- Add debugging messages for further investigation
- Allow file names to have spaces in them. The regex that is detecting
illegal file name characters has whitespace, so add the option to
ignore pattern whitespace. This allows file names with spaces like
originally intended.
ferventcoder added a commit that referenced this issue Apr 22, 2016
* stable:
  (GH-702) Fully qualify shutdown.exe
  (maint) Suggest ignore checksum switch on error
  (GH-435) Get-FileName enhancements
  (maint) ignore .vscode folder
  (GH-535) install template information
  (GH-696) Approved/Failing statuses on install
  (maint) Provide better warning on non-admin prompt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.