[Enhancement] Checksum downloaded files #427

Closed
ferventcoder opened this Issue Feb 28, 2014 · 15 comments

Projects

None yet

5 participants

@ferventcoder
chocolatey member

Long story short, this should have been in here a long time ago.

@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Feb 28, 2014
@ferventcoder ferventcoder (GH-427) CheckSum structure
This adds the structure for a checksum on a file.
870f9f9
@ferventcoder ferventcoder self-assigned this Feb 28, 2014
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Feb 28, 2014
@ferventcoder ferventcoder (GH-427) Add MD5 tool and license 4c89fce
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Feb 28, 2014
@ferventcoder ferventcoder (GH-427) Checksum downloaded files
This provides the actual checks to determine if a checksum matches the value
that is passed to it. This function does nothing if no checksum is included in
the package.
1d1d9b9
@ferventcoder
chocolatey member

This is complete. Packages need to opt in. Over time the plan is to restrict packages for users to the ones that have included this and users would need to then opt in to "unsafe" packages.

@ferventcoder ferventcoder reopened this Feb 28, 2014
@ferventcoder
chocolatey member

Also need to be able to sum against sha1 hashes.

@ferventcoder
chocolatey member

Adding some additional commits here.

@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 1, 2014
@ferventcoder ferventcoder (GH-427) Remove md5.exe. Add checksum.exe
This removes md5.exe in favor of checksum, which can verify both md5 and sha1
checksums. Added checksumType to parameters across anything that can pass
checksum.
1b8eb4d
@ferventcoder
chocolatey member

Now this is good.

@rismoney
chocolatey member

so if there is a separate md5 file, do you grab that file, get content it into a var and append it like in your link?

@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 1, 2014
@ferventcoder ferventcoder (GH-427) Account for checksumming x64 urls as well 5519d60
@ferventcoder
chocolatey member

@rismoney not sure what you are asking...

@ferventcoder ferventcoder added 3 - Done and removed 2 - Working labels Mar 1, 2014
@gep13
chocolatey member
@ferventcoder
chocolatey member

@gep13 Hoping to. :)

@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 2, 2014
@ferventcoder ferventcoder (GH-427) add config for checksum on or off f5c541a
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 2, 2014
@ferventcoder ferventcoder (GH-427) Use remote checksums if available
Verify remote checksum for X-Checksum-Sha1 if it is available.
58d167a
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 3, 2014
@ferventcoder ferventcoder (GH-427) throw if checksum passed but no file exists b657f8a
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 3, 2014
@ferventcoder ferventcoder (GH-427) Default to md5 if setting is not sha1 cd00092
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 3, 2014
@ferventcoder ferventcoder (GH-427) specs for Get-ChecksumValid de70ee3
@ferventcoder
chocolatey member

There we go. Now it should really be closed. ;)

@jberezanski

How about renaming Get-ChecksumValid to Test-Checksum (or Test-FileChecksum)? It would be more consistent with Powershell cmdlet naming conventions and standard cmdlets, such as Test-Path, Test-Certificate or Test-Connection.

Or is it too late for that change...?

@ferventcoder
chocolatey member
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 17, 2014
@ferventcoder ferventcoder (GH-427) throw if checksum passed but no file exists 9b1792a
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 17, 2014
@ferventcoder ferventcoder (GH-427) Default to md5 if setting is not sha1 5503a6d
@ferventcoder ferventcoder added a commit to ferventcoder/chocolatey that referenced this issue Mar 17, 2014
@ferventcoder ferventcoder (GH-427) specs for Get-ChecksumValid 08eb945
@ferventcoder ferventcoder changed the title from [Enhancement] CheckSum downloaded files to [Enhancement] Checksum downloaded files Jun 8, 2014
@dtgm

ferventcoder, can you please add support for passing {{checksum}} with ChocoPkgUp.exe? It seems as though this useful feature is somewhat lost when it requires manually updating this information if the checksum is not provided via static URL to a file.

@ferventcoder
chocolatey member

Would you mind logging that over at https://github.com/chocolatey/chocolatey-package-updater? Thanks.

@dtgm dtgm referenced this issue in chocolatey/chocolatey-package-updater Oct 28, 2014
Closed

Support for passing {{checksum}} variable #7

@ferventcoder
chocolatey member

awesome. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment