This repository has been archived by the owner on Oct 11, 2021. It is now read-only.
(GH-43) Use Svg or Png for icons #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ferventcoder is this enough? Or do we need to be smarter about discerning the file type? |
| { | ||
| get | ||
| { | ||
| return "As per the [packaging guidelines]() icons should be either a png or svg file. Please see [here](https://github.com/chocolatey/package-validator/wiki/UsePngOrSvgForPackageIcons) for further information and guidance."; |
There was a problem hiding this comment.
Limit use of "here" as link text - fails accessibility standards.
|
@ferventcoder updated with your suggestions. |
| { | ||
| get | ||
| { | ||
| return "As per the [packaging guidelines]() icons should be either a png or svg file. Please see [wiki article](https://github.com/chocolatey/package-validator/wiki/UsePngOrSvgForPackageIcons) for further information and guidance."; |
There was a problem hiding this comment.
@ferventcoder doh! good catch! 😄
Fixed it up.
ferventcoder
added a commit
that referenced
this pull request
Dec 7, 2015
(GH-43) Use Svg or Png for icons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.