Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #658 and remove JSON writer/parser #664

Merged
merged 8 commits into from Jan 21, 2020
Merged

Fix #658 and remove JSON writer/parser #664

merged 8 commits into from Jan 21, 2020

Conversation

cprudhom
Copy link
Member

Fixes #658.

Changes proposed in this PR:

@codecov-io
Copy link

codecov-io commented Jan 21, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@04c1a28). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #664   +/-   ##
=========================================
  Coverage          ?   62.15%           
  Complexity        ?     9852           
=========================================
  Files             ?      634           
  Lines             ?    40152           
  Branches          ?     7672           
=========================================
  Hits              ?    24958           
  Misses            ?    12911           
  Partials          ?     2283
Impacted Files Coverage Δ Complexity Δ
...s/src/main/java/org/chocosolver/parser/Parser.java 0% <0%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c1a28...7d91440. Read the comment docs.

@cprudhom cprudhom changed the title Develop cpru Fix #658 Jan 21, 2020
@cprudhom
Copy link
Member Author

Wow.. I think I should have wait to push last commit...

@cprudhom cprudhom changed the title Fix #658 Fix #658 and remove JSON writer/parser Jan 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 21, 2020

This pull request fixes 3 alerts when merging 7d91440 into 68854de - view on LGTM.com

fixed alerts:

  • 1 for Array index out of bounds
  • 1 for Missing space in string literal
  • 1 for Constant loop condition

@ArthurGodet ArthurGodet merged commit d47faab into master Jan 21, 2020
@cprudhom cprudhom deleted the develop-cpru branch October 26, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Clean tests' messages
3 participants