Change values list to be label-centric #433

merged 7 commits into from Feb 21, 2014


None yet

2 participants

bruth commented Feb 21, 2014

Read b9289f9 for details.

bruth added some commits Feb 21, 2014
@bruth bruth Port search control to JavaScript 93b8f3e
@bruth bruth Port cilantro.models.value to JavaScript 4cc6f95
@bruth bruth Change primary lookup and rendering of values list using label
In most cases, the label and value are the same, however for the cases
where the value is a surrogate identifier, the label is the preferred
string to be rendered when representing a list of values.

Fix #428
@bruth bruth Increase max depth of blocks to a more lenient value of 3 dbd85a3
@bruth bruth Port cilantro.core to JavaScript
Increase max Serrano version to 2.3.2
@bruth bruth Prevent empty request when there are no labels to check 680abfb
@bruth bruth Set label on unknown items in the list for validation
This falls back to setting the value if Serrano < 2.3.2 since it
would cause a 422 error. It prints a warning to the console since this
will cause a buggy experience for non-primitive data fields.
@naegelyd naegelyd merged commit f993894 into 2.2 Feb 21, 2014

1 check passed

default The Travis CI build passed
@naegelyd naegelyd deleted the issue-428 branch Feb 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment