Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More stateful effects to override #2

Open
chpill opened this issue May 18, 2017 · 1 comment
Open

More stateful effects to override #2

chpill opened this issue May 18, 2017 · 1 comment
Assignees
@chpill

Comments

@chpill
Copy link
Owner

chpill commented May 18, 2017

While looking at #1, I also noticed a problem with the effects that are registered in https://github.com/Day8/re-frame/blob/cf61b2db1da360687c6b247888b29fb58bedf7cb/src/re_frame/fx.cljc

:dispatch :dispatch-later and :dispatch-n all use the global dispatch. :deregister-event-handler uses the global registry.

So we will also need to swap them with "local" version when we instanciate a frank...

The solution here will depend on what comes out of #1
@chpill chpill self-assigned this May 18, 2017
@chpill
Copy link
Owner Author

chpill commented May 19, 2017

c3e2838

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chpill chpill

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chpill