New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for people to use XDG_CONFIG_HOME #106

Merged
merged 1 commit into from Apr 2, 2013

Conversation

Projects
None yet
2 participants
@gtmanfred

gtmanfred commented Apr 1, 2013

check if ~/.config/livestreamer/config exists before ~/.livestreamerrc

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Apr 1, 2013

Owner

This is nice, but you're not actually using the environment variable XDG_CONFIG_HOME?
You should probably check if it exists and then fall back on the default ~/.config. Take a look on how I do a similar check for XDG_CACHE_HOME in cache.py.

Owner

chrippa commented Apr 1, 2013

This is nice, but you're not actually using the environment variable XDG_CONFIG_HOME?
You should probably check if it exists and then fall back on the default ~/.config. Take a look on how I do a similar check for XDG_CACHE_HOME in cache.py.

@gtmanfred

This comment has been minimized.

Show comment
Hide comment
@gtmanfred

gtmanfred Apr 2, 2013

Bah my bad, i pushed from the wrong repo

gtmanfred commented Apr 2, 2013

Bah my bad, i pushed from the wrong repo

allow for people to use XDG_CONFIG_HOME
check if ~/.config/livestreamer/config exists before ~/.livestreamerrc
@gtmanfred

This comment has been minimized.

Show comment
Hide comment
@gtmanfred

gtmanfred Apr 2, 2013

should be fixed now thanks

gtmanfred commented Apr 2, 2013

should be fixed now thanks

chrippa added a commit that referenced this pull request Apr 2, 2013

Merge pull request #106 from gtmanfred/master
cli: Attempt to load config from $XDG_CONFIG_HOME/livestreamer/config if it exists.

@chrippa chrippa merged commit ea80591 into chrippa:master Apr 2, 2013

1 check passed

default The Travis build passed
Details

javiercantero pushed a commit to javiercantero/livestreamer that referenced this pull request Jan 7, 2017

Fix for erroneous escape coding the livecoding plugin. Fixes chrippa#106
 (chrippa#121)

* bug fix for bad escape character in the livecoding url regex

* updated the regex for the livecodingtv so that it correctly find the streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment