Add support for Hashd.tv #184

Merged
merged 1 commit into from Sep 29, 2013

Conversation

Projects
None yet
2 participants
@kasper93
Contributor

kasper93 commented Sep 28, 2013

My friend asked me for this plugin. It's quite simple and should be fine, of course any suggestions are welcome :)

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Sep 28, 2013

Owner

Hello, this looks good except that the stream names for the livestreams could be improved.

  • the "current_video_height" key in the JSON can be used to make a more useful name, like "720p".
  • you should select a "main server" and then name the rest of the servers <name>_alt_<server name>. You can either use the first server in the list as "main" or use the geo information available in the JSON to select it more intelligently.
Owner

chrippa commented Sep 28, 2013

Hello, this looks good except that the stream names for the livestreams could be improved.

  • the "current_video_height" key in the JSON can be used to make a more useful name, like "720p".
  • you should select a "main server" and then name the rest of the servers <name>_alt_<server name>. You can either use the first server in the list as "main" or use the geo information available in the JSON to select it more intelligently.
@kasper93

This comment has been minimized.

Show comment
Hide comment
@kasper93

kasper93 Sep 29, 2013

Contributor

Ok, I pushed new version. I used localization provided in json, but they aren't real based on my small test. We can leave as is or use http://freegeoip.net/json/ to get more real server location. What do you think?

Contributor

kasper93 commented Sep 29, 2013

Ok, I pushed new version. I used localization provided in json, but they aren't real based on my small test. We can leave as is or use http://freegeoip.net/json/ to get more real server location. What do you think?

chrippa added a commit that referenced this pull request Sep 29, 2013

@chrippa chrippa merged commit 3f60806 into chrippa:develop Sep 29, 2013

1 check passed

default The Travis CI build passed
Details
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Sep 29, 2013

Owner

Looks good, thanks for your contribution. :)

Owner

chrippa commented Sep 29, 2013

Looks good, thanks for your contribution. :)

javiercantero pushed a commit to javiercantero/livestreamer that referenced this pull request Jan 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment