New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crunchyroll plugin #262

Merged
merged 1 commit into from Jan 10, 2014

Conversation

Projects
None yet
2 participants
@asermax
Contributor

asermax commented Jan 10, 2014

First of all, thank you again for your support on the IRC channel, really helped me out to refine the plugin.

Ok now: I made this plugin to be able to access Crunchyroll's videos through livestreamer. It's based on this Plex plugin from where I took most of the logic and API calls.

One point that may be of concern: the API isn't really "public", as far as I'm concerned Crunchyroll uses it for their own applications on some devices (PS3, Xbox, Android, IOS and others). The plugin uses custom headers an a API token to try to pass as a PS3 console.

Please check it out and consider to merge the plugin into the codebase.
Let me know if I should review something or if you need me to squash the commits.

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Jan 10, 2014

Owner

Looks good, I found a few minor issues though:

  • You made a typo on line 225, should be warning, not warn
  • You added --crunchyroll-purge-credentials to playeropt, should be pluginopt
  • Add the new CLI options to docs/cli.rst
  • Add yourself to AUTHORS if you wish
  • Add stream weights, see src/livestreamer/plugins/justintv_common.py for a example on how to do this.
  • The 'adaptive' stream returned is actually a variant playlist containing the 'mid' and 'high' streams and should be ignored since Livestreamer doesn't support adaptive streaming.
  • You marked the plugin as capable of handling live streams in docs/plugin_matrix.rst, but the only live stream I found is on http://www.crunchyroll.com/live which ended a long time ago. So I assume it hasn't been tested or not supported at all in the plugin? Or are there other live streams?

And yes, I would prefer it if you squashed the commits.

Owner

chrippa commented Jan 10, 2014

Looks good, I found a few minor issues though:

  • You made a typo on line 225, should be warning, not warn
  • You added --crunchyroll-purge-credentials to playeropt, should be pluginopt
  • Add the new CLI options to docs/cli.rst
  • Add yourself to AUTHORS if you wish
  • Add stream weights, see src/livestreamer/plugins/justintv_common.py for a example on how to do this.
  • The 'adaptive' stream returned is actually a variant playlist containing the 'mid' and 'high' streams and should be ignored since Livestreamer doesn't support adaptive streaming.
  • You marked the plugin as capable of handling live streams in docs/plugin_matrix.rst, but the only live stream I found is on http://www.crunchyroll.com/live which ended a long time ago. So I assume it hasn't been tested or not supported at all in the plugin? Or are there other live streams?

And yes, I would prefer it if you squashed the commits.

@asermax

This comment has been minimized.

Show comment
Hide comment
@asermax

asermax Jan 10, 2014

Contributor

About the live streams, it was a confusion on my part. Crunchyroll provides simulcasted shows, which I misunderstood as live shows, when they aren't quite that.
I haven't tested it against the live broadcast, so I'm going to remove it from the docs until I can try it out.

Going to work on those issues, squash and report back!

Contributor

asermax commented Jan 10, 2014

About the live streams, it was a confusion on my part. Crunchyroll provides simulcasted shows, which I misunderstood as live shows, when they aren't quite that.
I haven't tested it against the live broadcast, so I'm going to remove it from the docs until I can try it out.

Going to work on those issues, squash and report back!

@asermax

This comment has been minimized.

Show comment
Hide comment
@asermax

asermax Jan 10, 2014

Contributor

Done :) I think I took care of all the problems, let me know if there's something else.

Contributor

asermax commented Jan 10, 2014

Done :) I think I took care of all the problems, let me know if there's something else.

chrippa added a commit that referenced this pull request Jan 10, 2014

@chrippa chrippa merged commit 756fc21 into chrippa:develop Jan 10, 2014

1 check passed

default The Travis CI build passed
Details
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Jan 10, 2014

Owner

Great, thanks!

Owner

chrippa commented Jan 10, 2014

Great, thanks!

@asermax asermax deleted the asermax:crunchyroll branch Jan 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment