added chaturbate plugin #337

Merged
merged 1 commit into from Mar 20, 2014

Conversation

Projects
None yet
4 participants
@henkman
Contributor

henkman commented Mar 19, 2014

No description provided.

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Mar 19, 2014

Owner

Hello, I've found a few issues with your plugin:

  • You are importing unquote but it is not used.
  • The urlget function is now deprecated, please use the new API, e.g.
from livestreamer.plugin.api import http
res = http.get(url)
  • You can remove all the playlist parsing code and use return HLSStream.parse_variant_playlist(self.session, url) instead.
Owner

chrippa commented Mar 19, 2014

Hello, I've found a few issues with your plugin:

  • You are importing unquote but it is not used.
  • The urlget function is now deprecated, please use the new API, e.g.
from livestreamer.plugin.api import http
res = http.get(url)
  • You can remove all the playlist parsing code and use return HLSStream.parse_variant_playlist(self.session, url) instead.
@henkman

This comment has been minimized.

Show comment
Hide comment
@henkman

henkman Mar 19, 2014

Contributor

Your suggestions are implemented.

Contributor

henkman commented Mar 19, 2014

Your suggestions are implemented.

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Mar 19, 2014

Owner

Please squash your commits into one (git rebase -i HEAD~2, select fixup on the second commit, then git push --force)

Owner

chrippa commented Mar 19, 2014

Please squash your commits into one (git rebase -i HEAD~2, select fixup on the second commit, then git push --force)

@henkman

This comment has been minimized.

Show comment
Hide comment
@henkman

henkman Mar 20, 2014

Contributor

The commits are merged. Thanks for the instructions, I am still learning to use git

Contributor

henkman commented Mar 20, 2014

The commits are merged. Thanks for the instructions, I am still learning to use git

chrippa added a commit that referenced this pull request Mar 20, 2014

@chrippa chrippa merged commit c5ad0d0 into chrippa:develop Mar 20, 2014

1 check passed

default The Travis CI build passed
Details
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Mar 20, 2014

Owner

Thanks!

Owner

chrippa commented Mar 20, 2014

Thanks!

@dynamitemedia

This comment has been minimized.

Show comment
Hide comment
@dynamitemedia

dynamitemedia Mar 22, 2014

not trying to open this sorry but tried with your latest version and get no such plugin error

not trying to open this sorry but tried with your latest version and get no such plugin error

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Mar 22, 2014

Owner

not trying to open this sorry but tried with your latest version and get no such plugin error

It is not available in the release, you must install the latest git version.

Owner

chrippa commented Mar 22, 2014

not trying to open this sorry but tried with your latest version and get no such plugin error

It is not available in the release, you must install the latest git version.

@dynamitemedia

This comment has been minimized.

Show comment
Hide comment
@dynamitemedia

dynamitemedia Mar 23, 2014

is there instructions how to do that on windows as well as a linux box ?

is there instructions how to do that on windows as well as a linux box ?

@VackerSimon

This comment has been minimized.

Show comment
Hide comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment