added picarto plugin #352

Merged
merged 1 commit into from Apr 15, 2014

Conversation

Projects
None yet
2 participants
@henkman
Contributor

henkman commented Apr 15, 2014

Resolves #351 plugin request

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Apr 15, 2014

Owner

Looks good except for a couple of minor issues:

  • Use parse_qsd from livestreamer.utils instead of parse_qs, it returns a flat dict instead of a dict containing lists.
  • Import urlparse from livestreamer.compat instead, it has different package locations on Python 2 and 3.
  • I don't like this hardcoded RTMP URL, is this really how the original player behaves?
Owner

chrippa commented Apr 15, 2014

Looks good except for a couple of minor issues:

  • Use parse_qsd from livestreamer.utils instead of parse_qs, it returns a flat dict instead of a dict containing lists.
  • Import urlparse from livestreamer.compat instead, it has different package locations on Python 2 and 3.
  • I don't like this hardcoded RTMP URL, is this really how the original player behaves?
@henkman

This comment has been minimized.

Show comment
Hide comment
@henkman

henkman Apr 15, 2014

Contributor

The issues are fixed. The RTMP URL is indeed hardcoded in a javascript file on the site(https://www.picarto.tv/js/ds.js).

Contributor

henkman commented Apr 15, 2014

The issues are fixed. The RTMP URL is indeed hardcoded in a javascript file on the site(https://www.picarto.tv/js/ds.js).

chrippa added a commit that referenced this pull request Apr 15, 2014

@chrippa chrippa merged commit 664ab49 into chrippa:develop Apr 15, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Apr 15, 2014

Owner

Thanks!

Owner

chrippa commented Apr 15, 2014

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment