New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crunchyroll: correctly deal with unicode errors #388

Merged
merged 2 commits into from May 17, 2014

Conversation

Projects
None yet
2 participants
@asermax
Contributor

asermax commented May 11, 2014

Noticed the problem given the error explained on #387

@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa May 17, 2014

Owner

I think we want to avoid using the u'' prefix since it does not exist on Python 3.2. Instead we should add from __future__ import unicode_literals to the affected files. This will turn the strings into unicode on Python 2 just like they already are on Python 3.

Owner

chrippa commented May 17, 2014

I think we want to avoid using the u'' prefix since it does not exist on Python 3.2. Instead we should add from __future__ import unicode_literals to the affected files. This will turn the strings into unicode on Python 2 just like they already are on Python 3.

@asermax

This comment has been minimized.

Show comment
Hide comment
@asermax

asermax May 17, 2014

Contributor

Wow didn't know about that xD kay, imma redo the commits then.

Contributor

asermax commented May 17, 2014

Wow didn't know about that xD kay, imma redo the commits then.

@asermax asermax changed the title from Crunchyroll: add unicode prefix to formatted error strings to Crunchyroll: correctly deal with unicode errors May 17, 2014

chrippa added a commit that referenced this pull request May 17, 2014

Merge pull request #388 from asermax/crunchyroll-unicode-fix
Crunchyroll: correctly deal with unicode errors

@chrippa chrippa merged commit 036639d into chrippa:develop May 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa May 17, 2014

Owner

Thanks!

Owner

chrippa commented May 17, 2014

Thanks!

@asermax asermax deleted the asermax:crunchyroll-unicode-fix branch May 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment