plugin.gaminglive: basic support for gaming live #468

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
@chhe
Contributor

chhe commented Aug 2, 2014

My first attempt to do something beyond "Hello World" in Python.

GamingLive.TV is a new streaming portal which is in a somewhat closed alpha state right now. You can't register as new user and streamers are invited by GamingLive directly.

The plugin supports live-streams only (i believe there are no VODs at the moment). No special parameters or configuration. You just type:

livestreamer http://staging.gaminglive.tv/#/channels/h4r live

Since it is a new platform there not many streamers at any given time. You can get a list of all live broadcasters with this url:

http://staging.gaminglive.tv/#/channels

The code should be straight forward. I don't like the way i handled the JSON response (lots of if not ... return). I tried to use your schema validation API but i did not understand it enough to make it work.

As i said i have close to no experience with Python so any additional comment would be greatly appreciated.

And also this is my first pull-request, if i did anything wrong please let me know.

Thanks.

@chhe

This comment has been minimized.

Show comment
Hide comment
@chhe

chhe Aug 2, 2014

Contributor

Gaminglive.TV went into open alpha while i was writing the pull-request. This also changed the stream URLs. Hence the second commit. Sorry about that.

Contributor

chhe commented Aug 2, 2014

Gaminglive.TV went into open alpha while i was writing the pull-request. This also changed the stream URLs. Hence the second commit. Sorry about that.

chrippa added a commit that referenced this pull request Aug 2, 2014

Merge pull request #468 from chhe/gaming-live
Added plugin for gaminglive.tv.
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Aug 2, 2014

Owner

Thanks!

PS. You might want to set your text editor to use Unix line endings instead of DOS ones in the future as I believe 99% open source projects use that. ;-)

Owner

chrippa commented Aug 2, 2014

Thanks!

PS. You might want to set your text editor to use Unix line endings instead of DOS ones in the future as I believe 99% open source projects use that. ;-)

@chrippa chrippa closed this Aug 2, 2014

@chhe

This comment has been minimized.

Show comment
Hide comment
@chhe

chhe Aug 2, 2014

Contributor

Thanks for the info. I thought PyCharm defaults to Linux line endings and didn't bother to check. Sorry!

Contributor

chhe commented Aug 2, 2014

Thanks for the info. I thought PyCharm defaults to Linux line endings and didn't bother to check. Sorry!

@chhe chhe deleted the chhe:gaming-live branch Mar 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment