New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins.gaminglive: VOD support fixed #808

Merged
merged 1 commit into from Mar 22, 2015

Conversation

Projects
None yet
3 participants
@chhe
Contributor

chhe commented Mar 20, 2015

For some reason we have to create the RTMPStream with "live" = True for
VODs too or they won't play. I also changed the name of the VOD quality
from the video title to "source". It made more sense to me.

plugins.gaminglive: VOD support fixed
For some reason we have to create the RTMPStream with "live" = True for
VODs too or they won't play. I also changed the name of the VOD quality
from the video title to "source". It made more sense to me.

chrippa added a commit that referenced this pull request Mar 22, 2015

Merge pull request #808 from chhe/gl-vod-fix
plugins.gaminglive: VOD support fixed

@chrippa chrippa merged commit ecfa360 into chrippa:develop Mar 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@chrippa

This comment has been minimized.

Show comment
Hide comment
@chrippa

chrippa Mar 22, 2015

Owner

Thanks!

Owner

chrippa commented Mar 22, 2015

Thanks!

@chhe chhe deleted the chhe:gl-vod-fix branch Mar 22, 2015

@kasper93

This comment has been minimized.

Show comment
Hide comment
@kasper93

kasper93 Mar 23, 2015

Contributor

@chhe: Weird enough. It works fine for me with live beeing set to false, but I prabably use different tools. Nevermind.

As for the "source" change I find this misleading. VOD's are not source per say, they are reencoded (quite hard). And since there is only one stream to pick I figured to put some usefull info.

Contributor

kasper93 commented on c6e4791 Mar 23, 2015

@chhe: Weird enough. It works fine for me with live beeing set to false, but I prabably use different tools. Nevermind.

As for the "source" change I find this misleading. VOD's are not source per say, they are reencoded (quite hard). And since there is only one stream to pick I figured to put some usefull info.

@chhe chhe restored the chhe:gl-vod-fix branch Apr 5, 2015

@chhe chhe deleted the chhe:gl-vod-fix branch Apr 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment