Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Track coinbase transactions #64
Thanks for this PR.
I've played around with regtest mode RPC to better understand these transactions, since I've never received newly-mined coins myself. I now understand that coinbase transactions are in the category "immature" and once they reach 100 confirmations they become "generate". Also coinbase transactions have the key "coinbase" in their inputs as a result of
I think this line in
Have you tested this with Electrum wallet? Does Electrum display immature or coinbase transactions in a special way?
You're absolutely right. I didn't check for having the server running while receiving a coinbase transaction. I've updated the commit to check for coinbase transactions in
I did test this with Electrum wallet. However, I haven't had the server running while receiving a coinbase. I can't think of a way it would break since the logic is handled the same as when starting up, but that is definitely something to think about. Electrum displays these transactions normally, except when immature it displays a separate balance in brackets next to the main balance indicating how much is not yet matured.
Also, I opened a PR bitcoin/bitcoin#14653 to fix the help text for