Skip to content

Loading…

[Firefox Mobile] Number of connected domains makes no sense #1019

Closed
WalterWW opened this Issue · 10 comments

3 participants

@WalterWW

Sometimes the number displayed under 'domains connected' is too big:

http://i.imgur.com/V29r3sM.jpg

I've also seen 3 of 2 as well as 1 of 0.

(The above screenshot is after opening this via reddit: http://i.imgur.com/aq9WtgZ.gifv)

@gorhill

Can I have the URL on reddit through which http://i.imgur.com/aq9WtgZ.gifv was opened?

@gorhill

Can I see the content of the dynamic filtering pane for when that issue occurs?

@WalterWW

At that time I didn't have dynamic filtering enabled, so it was purely adblock filters.

In the meantime I've played around with it some more and have also enabled dynamic filtering. This is what it looks like with df enabled:

http://i.imgur.com/G44ZjPe.jpg

@gorhill

This is really difficult, I would need to step through the code, but then I have no mobile device.

@WalterWW

Hmm. A few things I've noticed so far:

  • The issue occurs when a link gets opened in a new tab (I have reddit set to open links in a new tab)
  • But it doesn't happen when manually selecting 'open in new tab' from the firefox context menu after long pressing the link (funnily enough it often shows 0 out of 0 domains when doing this though, so there's a bug here somewhere too)
  • After reloading the page, the number of connected domains displays correctly again

edit: I've also noticed that when a link opens in a new tab, the new tab shows about:blank for a moment before loading the page. Maybe ublock adds that to the connected domains counter for some reason?

@AlexVallat
Collaborator

@gorhill I've fixed a bunch of new tab issues with #1021, it might fix this too. I haven't been able to reproduce the original issue though, I think I might need a more static example than reddit to try it on.

@WalterWW

Static example to reproduce the issue:

Btw: I just followed the above and it showed 1 out of 1, then I tried it again and it showed 2 out of 1, so no idea how consistently that happens.

@AlexVallat
Collaborator

Thanks, with those steps I get 2 out of 1 domains connected. Applying the fix I mentioned I get 1 out of 1, so it looks like it's the same root cause.

@gorhill gorhill removed the investigating label
@gorhill

Fixed by #1021.

@gorhill gorhill closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.